[GitHub] [royale-asjs] greg-dove commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types

[GitBox <gi...@apache.org>]

greg-dove commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735914501


   > Hi @greg-dove could you take a look to this PR?
   > Thanks in advance for your help on this
   
   Sorry all, I can't look into this more deeply until this coming weekend earliest. But the Fixes for IDataInput/IDataOutput seem correct to me. 
   This situation with swf was probably overlooked because I was verifying Royale JS against Flex builds and not against swf builds of the same thing in Royale for actual remoting tests. (For all the low level tests with AMFBinaryData, that is done with both swf and JS in Royale.)
   The need for dual imports is valid here, because there are interfaces with method signatures that have arguments that reference other native interfaces in their types in swf, so you can't really 'override' them. Even if it was possible, the effort to make all this 'one' single api to avoid the conditional imports is IMO not worth it. Probably the swf stubs that I added thinking I could do that should be removed, so it is not confusing, but I'm just musing without spending time checking to see.... I can look into it more on of after this next weekend, or if others want to look at that earlier, please go for it!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org