You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2022/08/12 13:44:42 UTC
[plc4x] 04/05: fix(plc4go/cbus): fixed write
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 191162deb76d33f74cf26e5c27f69676e520a1f6
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Aug 12 15:44:19 2022 +0200
fix(plc4go/cbus): fixed write
---
plc4go/internal/cbus/Connection.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/plc4go/internal/cbus/Connection.go b/plc4go/internal/cbus/Connection.go
index b4fe0603d..f341de773 100644
--- a/plc4go/internal/cbus/Connection.go
+++ b/plc4go/internal/cbus/Connection.go
@@ -181,8 +181,7 @@ func (c *Connection) setupConnection(ch chan plc4go.PlcConnectionConnectResult)
{
log.Debug().Msg("Send a reset")
requestTypeReset := readWriteModel.RequestType_RESET
- requestTypeResetByte := byte(readWriteModel.RequestType_RESET)
- requestReset := readWriteModel.NewRequestReset(requestTypeReset, &requestTypeResetByte, requestTypeReset, &requestTypeResetByte, requestTypeReset, nil, &requestTypeReset, requestTypeReset, readWriteModel.NewRequestTermination(), *cbusOptions)
+ requestReset := readWriteModel.NewRequestReset(requestTypeReset, &requestTypeReset, requestTypeReset, &requestTypeReset, requestTypeReset, nil, &requestTypeReset, requestTypeReset, readWriteModel.NewRequestTermination(), *cbusOptions)
cBusMessage := readWriteModel.NewCBusMessageToServer(requestReset, *requestContext, *cbusOptions)
receivedResetEchoChan := make(chan bool)
@@ -319,10 +318,11 @@ func (c *Connection) setupConnection(ch chan plc4go.PlcConnectionConnectResult)
}()
}
+// This is used for connection setup
func (c *Connection) sendCalDataWrite(ch chan plc4go.PlcConnectionConnectResult, paramNo readWriteModel.Parameter, parameterValue readWriteModel.ParameterValue, requestContext *readWriteModel.RequestContext, cbusOptions *readWriteModel.CBusOptions) bool {
// TODO: we assume that is always a one byte request otherwise we need to map the length here
calData := readWriteModel.NewCALDataWrite(paramNo, 0x0, parameterValue, readWriteModel.CALCommandTypeContainer_CALCommandWrite_3Bytes, nil, *requestContext)
- directCommand := readWriteModel.NewRequestDirectCommandAccess(calData, 0x40, nil, nil, 0x0, readWriteModel.NewRequestTermination(), *cbusOptions)
+ directCommand := readWriteModel.NewRequestDirectCommandAccess(calData /*we don't want a alpha otherwise the PCI will auto-switch*/, nil, 0x40, nil, nil, 0x0, readWriteModel.NewRequestTermination(), *cbusOptions)
cBusMessage := readWriteModel.NewCBusMessageToServer(directCommand, *requestContext, *cbusOptions)
directCommandAckChan := make(chan bool)