You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/11/14 22:28:38 UTC
Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and Dan Smith.
Bugs: geode-2107
https://issues.apache.org/jira/browse/geode-2107
Repository: geode
Description
-------
This is a thread leak we found in GEM-933.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java e953c0c
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06
Diff: https://reviews.apache.org/r/53745/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/#review155874
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Nov. 15, 2016, 1:33 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53745/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 1:33 a.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Bugs: geode-2107
> https://issues.apache.org/jira/browse/geode-2107
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is a thread leak we found in GEM-933.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java b41ace4
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java 97cfac7
>
> Diff: https://reviews.apache.org/r/53745/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/
-----------------------------------------------------------
(Updated Nov. 15, 2016, 1:33 a.m.)
Review request for geode, anilkumar gingade and Dan Smith.
Changes
-------
update the fix
Bugs: geode-2107
https://issues.apache.org/jira/browse/geode-2107
Repository: geode
Description
-------
This is a thread leak we found in GEM-933.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java b41ace4
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java 97cfac7
Diff: https://reviews.apache.org/r/53745/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/
-----------------------------------------------------------
(Updated Nov. 15, 2016, 12:27 a.m.)
Review request for geode, anilkumar gingade and Dan Smith.
Changes
-------
Please ignore the my previous change; I updated the wrong review request.
Bugs: geode-2107
https://issues.apache.org/jira/browse/geode-2107
Repository: geode
Description
-------
This is a thread leak we found in GEM-933.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java e953c0c
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06
Diff: https://reviews.apache.org/r/53745/diff/
Testing (updated)
-------
Thanks,
xiaojian zhou
Re: Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/
-----------------------------------------------------------
(Updated Nov. 15, 2016, 12:25 a.m.)
Review request for geode, anilkumar gingade and Dan Smith.
Bugs: geode-2107
https://issues.apache.org/jira/browse/geode-2107
Repository: geode
Description
-------
This is a thread leak we found in GEM-933.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java e953c0c
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06
Diff: https://reviews.apache.org/r/53745/diff/
Testing (updated)
-------
Tests run so far. One of these tests is failing with a compatibility failure I'm investigating.
include $JTESTS/hct/backwardCompatibility/hctBackwardCompatibility.bt
include $JTESTS/newWan/newWanBackwardCompatibility.bt
//I'm seeing what might be a compatiblity failure with this test
cq/serialCQBridgeBackwardCompatibilityWithClientCache.conf edgeHosts=8 edgeVMsPerHost=1 edgeThreadsPerVM=2 bridgeHosts=3 bridgeVMsPerHost=1 bridgeThreadsPerVM=2
parReg/bridge/concParRegHABridgeCompat.conf edgeHosts=8 edgeVMsPerHost=1 edgeThreadsPerVM=5 bridgeHosts=5 bridgeVMsPerHost=1 bridgeThreadsPerVM=5 redundantCopies=2 numVMsToStop=2 numAccessors=1 numEmptyClients=1 numThinClients=1 version1=default version2=822 version3=822 version4=822 version5=822 version6=822 version7=822 version8=822
delta/feederIsCurrentVersionClient.conf
A = bridge bridgeHosts = 2 bridgeVMsPerHost = 1 bridgeThreadsPerVM = 1
B = feed feedHosts = 1 feedVMsPerHost = 1 feedThreadsPerVM = 1
C = edge edgeHosts = 2 edgeVMsPerHost = 1 edgeThreadsPerVM = 1
D = edgeOld edgeOldHosts = 2 edgeOldVMsPerHost = 1 edgeOldThreadsPerVM = 1
nPutThreads=10 nPutKeyRange=10 version1=default version2=822
// validation for old and current client where feeder is old client
delta/feederIsOldVersionClient.conf
A = bridge bridgeHosts = 2 bridgeVMsPerHost = 1 bridgeThreadsPerVM = 1
B = feed feedHosts = 1 feedVMsPerHost = 1 feedThreadsPerVM = 1
C = edge edgeHosts = 2 edgeVMsPerHost = 1 edgeThreadsPerVM = 1
D = edgeOld edgeOldHosts = 2 edgeOldVMsPerHost = 1 edgeOldThreadsPerVM = 1
nPutThreads=10 nPutKeyRange=10 version1=default version2=822
Thanks,
xiaojian zhou
Re: Review Request 53745: when a sender was stopped before becoming a
primary, the wait thread should be closed
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53745/#review155859
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java (line 1154)
<https://reviews.apache.org/r/53745/#comment225950>
I'm not sure a user is going to understand what this (info level) log message means. Can you rewrite this from the perspective of what the user needs to know about what happened, or remove the log message?
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java (line 416)
<https://reviews.apache.org/r/53745/#comment225953>
The way isPrimary is treated in this method is a bit confusing. Maybe is should actually be two different methods? Eg
setIsPrimary() {
sychronized(...) {
isPrimary = true;
notifyPrimaryLock();
}
}
//this method just does the notification:
notifyPrimaryLock() {
...
}
...
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java (line 494)
<https://reviews.apache.org/r/53745/#comment225951>
I think these checks probably belong in the while statement, above. Otherwise if the notify happens before this thread gets into the wait it will wait forever.
- Dan Smith
On Nov. 14, 2016, 10:28 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53745/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2016, 10:28 p.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Bugs: geode-2107
> https://issues.apache.org/jira/browse/geode-2107
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is a thread leak we found in GEM-933.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java e953c0c
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06
>
> Diff: https://reviews.apache.org/r/53745/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>