You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Kevin Menard <km...@servprise.com> on 2007/10/16 00:10:07 UTC

Re: svn commit: r584707 - /cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/ apache/cayenne/access/jdbc/SQLTemplateAction.java

Odd.  It's strange you were able to reproduce it, too.

-- 
Kevin


On 10/15/07 10:39 AM, "Andrus Adamchik" <an...@objectstyle.org> wrote:

> I just added this code to SQLTemplateAction... I have no idea why,
> but the unit test that was failing last night is now working. It is
> not even using SQLTemplate!
> 
> Andrus
> 
> 
> On Oct 15, 2007, at 11:27 AM, aadamchik@apache.org wrote:
> 
>> Author: aadamchik
>> Date: Mon Oct 15 01:27:55 2007
>> New Revision: 584707
>> 
>> URL: http://svn.apache.org/viewvc?rev=584707&view=rev
>> Log:
>> preserving early loop break for iterated results
>> 
>> Modified:
>>     cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/
>> main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java
>> 
>> Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/
>> src/main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java
>> URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/
>> cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/
>> jdbc/SQLTemplateAction.java?rev=584707&r1=584706&r2=584707&view=diff
>> ======================================================================
>> ========
>> --- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/
>> main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java
>> (original)
>> +++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/
>> main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java Mon
>> Oct 15 01:27:55 2007
>> @@ -161,6 +161,12 @@
>>                                  resultSet.close();
>>                              }
>>                          }
>> +
>> +                        // ignore possible following update counts
>> and bail early on
>> +                        // iterated results
>> +                        if (iteratedResult) {
>> +                            break;
>> +                        }
>>                      }
>>                  }
>>                  else {
>> 
>> 
>> 
> 

--