You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ASF Subversion and Git Services <as...@urd.zones.apache.org> on 2014/05/02 19:47:19 UTC

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42031
-----------------------------------------------------------


Commit 59d0b75e7943505c11d6b726d7aa9dae0bf06316 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59d0b75 ]

CLOUDSTACK-6257: Adding function to check state of VM


- ASF Subversion and Git Services


On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 10:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/codes.py 28e907c 
>   tools/marvin/marvin/lib/base.py d753098 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>