You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:06:49 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #20019: Change ParamsDict to a MutableMapping subclass

jedcunningham commented on a change in pull request #20019:
URL: https://github.com/apache/airflow/pull/20019#discussion_r762261951



##########
File path: airflow/models/param.py
##########
@@ -14,7 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-from typing import Any, Dict, Optional
+from typing import Any, Dict, ItemsView, MutableMapping, Optional, ValuesView

Review comment:
       Should we be getting `MutableMapping` from `collections.abc` instead? Feels a little weird to inherit from something out of typing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org