You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/04/05 20:35:43 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7405: Fix reserved consistentHashQueryParams entries causing internal server error instead of client error
ocket8888 commented on code in PR #7405:
URL: https://github.com/apache/trafficcontrol/pull/7405#discussion_r1158996816
##########
lib/go-tc/deliveryservices.go:
##########
@@ -49,6 +49,14 @@ const MaxRangeSliceBlockSize = 33554432
// values of a Delivery Service's 'Active' property (v3.0+).
type DeliveryServiceActiveState string
+// These names of URL query string parameters are not allowed to be in a
+// Delivery Service's "ConsistentHashQueryParams" set, because they collide with
+// query string parameters reserved for use by Traffic Router.
+const (
+ ReservedConsistentHashingQueryParameterFormat = "format"
+ ReservedConsistentHashingQueryParameterTRRED = "trred"
Review Comment:
I don't really care where they go, but I also don't think it matters that this doesn't describe what they are to Traffic Router. It describes what they are in the context of Delivery Service properties: disallowed values. Traffic Router doesn't use any part of this Go package, so nobody and nothing reading that code should ever need to understand how Traffic Router uses them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org