You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/12 17:11:11 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

sureshanaparti commented on a change in pull request #5216:
URL: https://github.com/apache/cloudstack/pull/5216#discussion_r687933746



##########
File path: api/src/main/java/com/cloud/storage/Snapshot.java
##########
@@ -26,7 +26,7 @@
 
 public interface Snapshot extends ControlledEntity, Identity, InternalIdentity, StateObject<Snapshot.State> {
     public enum Type {
-        MANUAL, RECURRING, TEMPLATE, HOURLY, DAILY, WEEKLY, MONTHLY;
+        MANUAL, RECURRING, TEMPLATE, HOURLY, DAILY, WEEKLY, MONTHLY, INTERNAL;

Review comment:
       Better to add a comment to indicate any new type can be added after INTERNAL (so that the internal enum value [7] doesn't change)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org