You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/16 09:06:49 UTC
[GitHub] [doris] morrySnow opened a new pull request, #15974: [fix](planner)wrong result when has order by under join
morrySnow opened a new pull request, #15974:
URL: https://github.com/apache/doris/pull/15974
# Proposed changes
Issue Number: close #xxx
## Problem summary
when we have order by under join, aggregate, etc. node. we do offset twice if there is a exchange node on the top of merging exchange node.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #15974:
URL: https://github.com/apache/doris/pull/15974#issuecomment-1384376526
> The planner result is not checked in the case?
if offset and limit set to incorrect value, the result will be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
dataroaring commented on PR #15974:
URL: https://github.com/apache/doris/pull/15974#issuecomment-1383760973
The planner result is not checked in the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15974:
URL: https://github.com/apache/doris/pull/15974#issuecomment-1385082265
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15974:
URL: https://github.com/apache/doris/pull/15974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15974:
URL: https://github.com/apache/doris/pull/15974#issuecomment-1383966562
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.91 seconds
load time: 505 seconds
storage size: 17123108290 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116121422_clickbench_pr_81208.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15974: [fix](planner)wrong result when has order by under join
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15974:
URL: https://github.com/apache/doris/pull/15974#issuecomment-1385082409
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org