You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by damnever <gi...@git.apache.org> on 2017/08/23 03:06:53 UTC
[GitHub] thrift pull request #1335: Add default message for TApplicationException
GitHub user damnever opened a pull request:
https://github.com/apache/thrift/pull/1335
Add default message for TApplicationException
Since some implementations may not set message field (field 1).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/damnever/thrift default-error-message
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1335
----
commit 407b86feafe97ed5213672edc3f1329dbef8fb31
Author: damnever <dx...@gmail.com>
Date: 2017-08-23T03:05:05Z
Add default message for TApplicationException since some implementations does not set message field
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1335: Add default message for TApplicationException
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1335#discussion_r136895273
--- Diff: lib/go/thrift/application_exception.go ---
@@ -30,6 +30,17 @@ const (
PROTOCOL_ERROR = 7
)
+var defaultApplicationExceptionMessage = map[int32]string{
+ UNKNOWN_APPLICATION_EXCEPTION: "unknown application exception",
+ UNKNOWN_METHOD: "unknown method",
+ INVALID_MESSAGE_TYPE_EXCEPTION: "invalid message type",
+ WRONG_METHOD_NAME: "wrong method name",
+ BAD_SEQUENCE_ID: "bad sequnce ID",
--- End diff --
Typo in the string
---
[GitHub] thrift pull request #1335: Add default message for TApplicationException
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1335
---
[GitHub] thrift issue #1335: Add default message for TApplicationException
Posted by damnever <gi...@git.apache.org>.
Github user damnever commented on the issue:
https://github.com/apache/thrift/pull/1335
https://issues.apache.org/jira/browse/THRIFT-4315
---
[GitHub] thrift issue #1335: Add default message for TApplicationException
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1335
In order to add this I need an Apache Jira ticket under the thrift project. Do you open one?
https://thrift.apache.org/docs/HowToContribute
---
[GitHub] thrift issue #1335: Add default message for TApplicationException
Posted by damnever <gi...@git.apache.org>.
Github user damnever commented on the issue:
https://github.com/apache/thrift/pull/1335
Type alias is not comparable, would it cause incompatibility problems?
---
[GitHub] thrift issue #1335: Add default message for TApplicationException
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1335
Would it perhaps make sense to change the const list into something that can simply be generated using stringer, and therefore it would always be automatic?
https://godoc.org/golang.org/x/tools/cmd/stringer
---