You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/12/27 16:36:45 UTC

[GitHub] hboutemy edited a comment on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

hboutemy edited a comment on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
URL: https://github.com/apache/maven/pull/197#issuecomment-450147594
 
 
   I reworked the PR, creating 2 initial little refactoring commits that make the later modification a lot easier to understand IMHO: see MNG-6533-2 branch
   With that 2 commits, I now can understand the main "Prefer passing the interim project in ProjectBuildingResult" commit...
   One little thing that I feel is not good: catch(Exception) in the last commit. is catching InvalidArtifactRTException not sufficient?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services