[jira] Commented: (HADOOP-2975) IPC server should not allocate a buffer for each request

["Hairong Kuang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601212#action_12601212 ] 

Hairong Kuang commented on HADOOP-2975:
---------------------------------------

The patch looks good. But one disadvantage is that it keeps on growing the buffer size but never shrinking it. One solution could be we allocate a big enough buffer which should fit most requests. For a bigger size request, we do dynamic allocation then throw it away after serialization.

> IPC server should not allocate a buffer for each request
> --------------------------------------------------------
>
>                 Key: HADOOP-2975
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2975
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.16.0
>            Reporter: Hairong Kuang
>         Attachments: Hadoop-2975-v1.patch
>
>
> Currently the IPC server allocates a buffer for each incoming request. The buffer is thrown away after the request is serialized. This leads to very inefficient heap utilization. It would be nicer if all requests from one connection could share a same common buffer since the ipc server has only one request is being read from a socket at a time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.