You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by Marvin Humphrey <ma...@rectangular.com> on 2014/12/18 05:53:37 UTC

[lucy-dev] Re: [VOTE] Apache Clownfish 0.4.2 RC 2

On Wed, Dec 17, 2014 at 8:44 PM, Marvin Humphrey <ma...@rectangular.com> wrote:

> [ ] +1 Release RC 2 as Apache Clownfish 0.4.2.
> [ ] +0
> [ ] -1 Do not release RC 2 as Apache Clownfish 0.4.2 because...

+1

Tested on OS X Yosemite with stock Perl.  Rather than test from the Apache
release archive directly, I first built the CPAN dists, expanded those, then
installed them to a custom directory and set PERL5LIB.

There was a glitch with Lucy's `./Build dist` -- it balked with the following
message:

  Parcel 'Lucy' defined twice in ../core/Lucy.cfp and ../core/Lucy.cfp at
  /Users/evmarvin/Desktop/p5lib/lib/perl5/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
  line 249.

However, I believe that problem is isolated to Lucy's `dist` action rather
than a manifestation of the bug which is affecting CPAN installation
(CLOWNFISH-18).

Marvin Humphrey

Re: [lucy-dev] Re: [VOTE] Apache Clownfish 0.4.2 RC 2

Posted by Logan Bell <lo...@gmail.com>.
+1

Both the C and Perl runtime compiled and tested fine for me on Mac OS
Yosemite. The version of Perl which I compiled this on was 5.20. The
'dist' action through no errors for me.

On Wed, Dec 17, 2014 at 8:53 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
> On Wed, Dec 17, 2014 at 8:44 PM, Marvin Humphrey <ma...@rectangular.com> wrote:
>
>> [ ] +1 Release RC 2 as Apache Clownfish 0.4.2.
>> [ ] +0
>> [ ] -1 Do not release RC 2 as Apache Clownfish 0.4.2 because...
>
> +1
>
> Tested on OS X Yosemite with stock Perl.  Rather than test from the Apache
> release archive directly, I first built the CPAN dists, expanded those, then
> installed them to a custom directory and set PERL5LIB.
>
> There was a glitch with Lucy's `./Build dist` -- it balked with the following
> message:
>
>   Parcel 'Lucy' defined twice in ../core/Lucy.cfp and ../core/Lucy.cfp at
>   /Users/evmarvin/Desktop/p5lib/lib/perl5/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
>   line 249.
>
> However, I believe that problem is isolated to Lucy's `dist` action rather
> than a manifestation of the bug which is affecting CPAN installation
> (CLOWNFISH-18).
>
> Marvin Humphrey

Re: [lucy-dev] Re: [VOTE] Apache Clownfish 0.4.2 RC 2

Posted by Nick Wellnhofer <we...@aevum.de>.
On 21/12/2014 22:05, Marvin Humphrey wrote:
> Yes, I'm still having issues.  I believe that the problem arises because the
> parcel registry is global.  If you create two CFCHierarchy objects within the
> same process which operate on the same source dir, the second one will collide
> when parsing the parcel file a second time.  (Other registries are also global
> and have the same issue, so the fix is not just a one-liner somewhere.)
>
> I'm pretty sure this is happening because Lucy's "dist" action depends on
> "pod".  When invoking "./Build dist" in a clean directory, first a
> CFCHierarchy object is created when building the "clownfish" action, and then
> a second one is created during "pod".
>
> This sequence of events does not seem to happen when invoking either the
> "code", "test" or "install" actions on a newly unpacked Lucy CPAN tarball.
> Therefore, though we still have issues, I intend to call the VOTE a success
> and finish the release.

Ah yes, I also hit this issue a while ago and it's related to the "pod" 
action. From what I recall, it should either reuse the CFCHierarchy object, or 
we need a call to CFCParcel_reap_singletons() somewhere. But I agree that this 
isn't release-critical.

Nick


Re: [lucy-dev] Re: [VOTE] Apache Clownfish 0.4.2 RC 2

Posted by Marvin Humphrey <ma...@rectangular.com>.
On Thu, Dec 18, 2014 at 4:36 AM, Nick Wellnhofer <we...@aevum.de> wrote:
> On 18/12/2014 05:53, Marvin Humphrey wrote:
>>
>> There was a glitch with Lucy's `./Build dist` -- it balked with the
>> following
>> message:
>>
>>    Parcel 'Lucy' defined twice in ../core/Lucy.cfp and ../core/Lucy.cfp at
>>
>> /Users/evmarvin/Desktop/p5lib/lib/perl5/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
>>    line 249.
>>
>> However, I believe that problem is isolated to Lucy's `dist` action rather
>> than a manifestation of the bug which is affecting CPAN installation
>> (CLOWNFISH-18).
>
>
> This very much looks like CLOWNFISH-18 and this really shouldn't happen with
> RC2. Are you sure you used RC2 when you got that error message? Using RC2,
> `./Build dist` works fine for me.

Yes, I'm still having issues.  I believe that the problem arises because the
parcel registry is global.  If you create two CFCHierarchy objects within the
same process which operate on the same source dir, the second one will collide
when parsing the parcel file a second time.  (Other registries are also global
and have the same issue, so the fix is not just a one-liner somewhere.)

I'm pretty sure this is happening because Lucy's "dist" action depends on
"pod".  When invoking "./Build dist" in a clean directory, first a
CFCHierarchy object is created when building the "clownfish" action, and then
a second one is created during "pod".

This sequence of events does not seem to happen when invoking either the
"code", "test" or "install" actions on a newly unpacked Lucy CPAN tarball.
Therefore, though we still have issues, I intend to call the VOTE a success
and finish the release.

Marvin Humphrey

Re: [lucy-dev] Re: [VOTE] Apache Clownfish 0.4.2 RC 2

Posted by Nick Wellnhofer <we...@aevum.de>.
On 18/12/2014 05:53, Marvin Humphrey wrote:
> There was a glitch with Lucy's `./Build dist` -- it balked with the following
> message:
>
>    Parcel 'Lucy' defined twice in ../core/Lucy.cfp and ../core/Lucy.cfp at
>    /Users/evmarvin/Desktop/p5lib/lib/perl5/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
>    line 249.
>
> However, I believe that problem is isolated to Lucy's `dist` action rather
> than a manifestation of the bug which is affecting CPAN installation
> (CLOWNFISH-18).

This very much looks like CLOWNFISH-18 and this really shouldn't happen with 
RC2. Are you sure you used RC2 when you got that error message? Using RC2, 
`./Build dist` works fine for me.

Nick