You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/06/04 09:40:53 UTC

[jira] Created: (SLING-1545) ScripteEngineManagerFactory is not thread safe

ScripteEngineManagerFactory is not thread safe
----------------------------------------------

                 Key: SLING-1545
                 URL: https://issues.apache.org/jira/browse/SLING-1545
             Project: Sling
          Issue Type: Improvement
          Components: Scripting
    Affects Versions: Scripting Core 2.0.12
            Reporter: Felix Meschberger
             Fix For: Scripting Core 2.0.12


The ScriptEngineManagerFactory class is not thread-safe:

  * Access to the engineSpiBundles, engineSpiServices fields (lists) are not guarded
  * Calls to refreshScriptEngineManager are not guarded

This may cause improper states under certain circumstances.

Accesses to these internal fields and methods should properly be guarded.

In addition, replacement of the List as collection of the SPI bundles and service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (SLING-1545) ScripteEngineManagerFactory is not thread safe

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler reassigned SLING-1545:
---------------------------------------

    Assignee: Carsten Ziegeler

> ScripteEngineManagerFactory is not thread safe
> ----------------------------------------------
>
>                 Key: SLING-1545
>                 URL: https://issues.apache.org/jira/browse/SLING-1545
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.0.12
>            Reporter: Felix Meschberger
>            Assignee: Carsten Ziegeler
>             Fix For: Scripting Core 2.0.12
>
>
> The ScriptEngineManagerFactory class is not thread-safe:
>   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not guarded
>   * Calls to refreshScriptEngineManager are not guarded
> This may cause improper states under certain circumstances.
> Accesses to these internal fields and methods should properly be guarded.
> In addition, replacement of the List as collection of the SPI bundles and service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SLING-1545) ScripteEngineManagerFactory is not thread safe

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-1545.
-------------------------------------

    Resolution: Fixed

I changed the lists to sets and refactored the code. The old script manager is now marked invalid on changes and recreated on next access. This avoids blocking the bind/unbind method for a longer time.
Changed in revision 1024145

> ScripteEngineManagerFactory is not thread safe
> ----------------------------------------------
>
>                 Key: SLING-1545
>                 URL: https://issues.apache.org/jira/browse/SLING-1545
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.0.12
>            Reporter: Felix Meschberger
>            Assignee: Carsten Ziegeler
>             Fix For: Scripting Core 2.0.12
>
>
> The ScriptEngineManagerFactory class is not thread-safe:
>   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not guarded
>   * Calls to refreshScriptEngineManager are not guarded
> This may cause improper states under certain circumstances.
> Accesses to these internal fields and methods should properly be guarded.
> In addition, replacement of the List as collection of the SPI bundles and service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (SLING-1545) ScripteEngineManagerFactory is not thread safe

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-1545.
-----------------------------------


> ScripteEngineManagerFactory is not thread safe
> ----------------------------------------------
>
>                 Key: SLING-1545
>                 URL: https://issues.apache.org/jira/browse/SLING-1545
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.0.14
>            Reporter: Felix Meschberger
>            Assignee: Carsten Ziegeler
>             Fix For: Scripting Core 2.0.14
>
>
> The ScriptEngineManagerFactory class is not thread-safe:
>   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not guarded
>   * Calls to refreshScriptEngineManager are not guarded
> This may cause improper states under certain circumstances.
> Accesses to these internal fields and methods should properly be guarded.
> In addition, replacement of the List as collection of the SPI bundles and service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.