You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/09/09 19:29:25 UTC

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4352

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................

IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
63 files changed, 117 insertions(+), 70 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/4352/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has uploaded a new patch set (#3).

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................

IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
main() function used in most gtest unit tests.

3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/common/init.h
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/free-pool.h
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/testutil/gtest-util.h
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/perf-counters-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
73 files changed, 169 insertions(+), 422 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/4352/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Hello Lars Volker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4352

to look at the new patch set (#4).

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................

IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
main() function used in most gtest unit tests.

3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests. The only exception is promise-test
for which I added a TODO since the fix seems non-trivial.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/common/init.h
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-sse-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/free-pool.h
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/testutil/gtest-util.h
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/perf-counters-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
73 files changed, 169 insertions(+), 421 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/4352/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 1:

I decided to add a macro for the common main() instead of going the library route. The library route seemed a little complicated because we'd need to muck with how we add tests in our CMakeLists.txt (add dependencies or add a new ADD_STANDARD_TEST macro). Seemed easier this way.

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/old-hash-table-test.cc
File be/src/exec/old-hash-table-test.cc:

PS2, Line 23: #include "testutil/gtest-util.h"
> Still needed?
Done


PS2, Line 24: #include "common/init.h"
            : #include "common/compiler-util.h"
> nit: preserve alphabetical order (here and in other files)
Done


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/parquet-plain-test.cc
File be/src/exec/parquet-plain-test.cc:

PS2, Line 22: #include <gtest/gtest.h>
> nit: not needed with the gtest-util import. We could remove this from all o
Done


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/runtime/buffered-tuple-stream-test.cc
File be/src/runtime/buffered-tuple-stream-test.cc:

PS2, Line 1171: BE_TEST
> it was not clear to me why this was set to BE_TEST here, while we also init
The parameter indicates that we are running a BE unit test. I don't see how starting a JVM or enabling FE support would change that.

Modified comment in init.h. Actually all BE unit tests must indicate that they are a test to get the logging working correctly.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/testutil/gtest-util.h
File be/src/testutil/gtest-util.h:

Line 32: // Basic main() function to be used in gtest unit tests. Does not start a JVM
> nit: wrap at 90 characters
Done


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:

PS2, Line 27: #include "common/init.h"
> still needed?
No. Done.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

PS2, Line 22: #include "common/init.h"
> It is needed? It's seems to be included in gtest-util.h anyways
Removed everywhere we don't need it.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/metrics-test.cc
File be/src/util/metrics-test.cc:

PS2, Line 386: 
> I don't think this gets executed anymore, since IMPALA_TEST_MAIN() will set
This change was wrong. Fixed.


PS2, Line 26: #include "util/jni-util.h"
> not needed anymore?
Removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 1:

Thanks for fixing this. While we are at it, why don't we create a common library for the tests containing a default main() function and then just link all tests against it? This way we could get away with less code and wouldn't need to maintain main() functions in all tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has uploaded a new patch set (#2).

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................

IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
main() function used in most gtest unit tests.

3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/testutil/gtest-util.h
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
65 files changed, 140 insertions(+), 317 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/4352/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 2:

(9 comments)

Made a first pass. I'm still building the change to validate it myself.

http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/old-hash-table-test.cc
File be/src/exec/old-hash-table-test.cc:

PS2, Line 23: #include "testutil/gtest-util.h"
Still needed?


PS2, Line 24: #include "common/init.h"
            : #include "common/compiler-util.h"
nit: preserve alphabetical order (here and in other files)


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/parquet-plain-test.cc
File be/src/exec/parquet-plain-test.cc:

PS2, Line 22: #include <gtest/gtest.h>
nit: not needed with the gtest-util import. We could remove this from all other tests, too.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/runtime/buffered-tuple-stream-test.cc
File be/src/runtime/buffered-tuple-stream-test.cc:

PS2, Line 1171: BE_TEST
it was not clear to me why this was set to BE_TEST here, while we also initialize the FE in the next line. Maybe add an explanation to the comment in common/init.h, or even add an overload that removes the parameter, since none of the be tests seem to use it.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/testutil/gtest-util.h
File be/src/testutil/gtest-util.h:

Line 32: // Basic main() function to be used in gtest unit tests. Does not start a JVM
nit: wrap at 90 characters


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:

PS2, Line 27: #include "common/init.h"
still needed?


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

PS2, Line 22: #include "common/init.h"
It is needed? It's seems to be included in gtest-util.h anyways


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/metrics-test.cc
File be/src/util/metrics-test.cc:

PS2, Line 386: 
I don't think this gets executed anymore, since IMPALA_TEST_MAIN() will set the respective parameter in InitCommonRuntime to false. Is this change intended? I couldn't tell from the code in this file.


PS2, Line 26: #include "util/jni-util.h"
not needed anymore?


-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 4: Code-Review+2

rebase

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 3: Code-Review+1

Thanks for fixing this.

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


IMPALA-4091: Fix backend unit to log in logs/be_tests.

1. Many backend unit tests did not follow proper initialization
using InitCommonRuntime(), and as a result did not write their
logs into the logs/be_tests directory.

2. Added an IMPALA_TEST_MAIN() macro that stamps out the common
main() function used in most gtest unit tests.

3. Tests added via ADD_UDF_TEST in a CMakeLists.txt did not
have the logging dir set up properly.

Testing: I validated that every test produces a corresponding
.INFO file in logs/be_tests. The only exception is promise-test
for which I added a TODO since the fix seems non-trivial.

Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Reviewed-on: http://gerrit.cloudera.org:8080/4352
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/atomic-test.cc
M be/src/common/init.h
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/old-hash-table-test.cc
M be/src/exec/parquet-plain-test.cc
M be/src/exec/parquet-version-test.cc
M be/src/exec/read-write-util-test.cc
M be/src/exec/row-batch-list-test.cc
M be/src/exec/zigzag-test.cc
M be/src/experiments/string-search-sse-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-util-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/collection-value-builder-test.cc
M be/src/runtime/decimal-test.cc
M be/src/runtime/free-pool-test.cc
M be/src/runtime/free-pool.h
M be/src/runtime/hdfs-fs-cache-test.cc
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-tracker-test.cc
M be/src/runtime/multi-precision-test.cc
M be/src/runtime/parallel-executor-test.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/string-buffer-test.cc
M be/src/runtime/string-value-test.cc
M be/src/runtime/thread-resource-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/scheduling/backend-config-test.cc
M be/src/scheduling/simple-scheduler-test.cc
M be/src/service/hs2-util-test.cc
M be/src/service/query-options-test.cc
M be/src/service/session-expiry-test.cc
M be/src/testutil/gtest-util.h
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
M be/src/util/benchmark-test.cc
M be/src/util/bit-util-test.cc
M be/src/util/bitmap-test.cc
M be/src/util/blocking-queue-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/coding-util-test.cc
M be/src/util/debug-util-test.cc
M be/src/util/decompress-test.cc
M be/src/util/dict-test.cc
M be/src/util/error-util-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/fixed-size-hash-table-test.cc
M be/src/util/internal-queue-test.cc
M be/src/util/logging-support-test.cc
M be/src/util/lru-cache-test.cc
M be/src/util/metrics-test.cc
M be/src/util/parse-util-test.cc
M be/src/util/perf-counters-test.cc
M be/src/util/pretty-printer-test.cc
M be/src/util/promise-test.cc
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor-test.cc
M be/src/util/redactor-unconfigured-test.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/string-parser-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread-pool-test.cc
M be/src/util/uid-util-test.cc
M be/src/util/webserver-test.cc
73 files changed, 169 insertions(+), 421 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>