You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/06 21:51:00 UTC

[jira] [Work logged] (GOBBLIN-1352) Ensure Helix workflows are cleaned up on cluster start up in centralized mode

     [ https://issues.apache.org/jira/browse/GOBBLIN-1352?focusedWorklogId=532152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532152 ]

ASF GitHub Bot logged work on GOBBLIN-1352:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jan/21 21:50
            Start Date: 06/Jan/21 21:50
    Worklog Time Spent: 10m 
      Work Description: sv2000 opened a new pull request #3191:
URL: https://github.com/apache/incubator-gobblin/pull/3191


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1352
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   As part of the changes introduced in GOBBLIN-1319, the Helix workflow names were modified to include a special prefix. However, this prefix is intended for use in distributed mode. As a consequence of this change, the workflows are no longer being cleaned up on cluster start up leading to a leak in Znodes. Further, since the workflows are left in the START state, the Yarn autoscaling manager requests more containers than needed.
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Added unit test.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 532152)
    Remaining Estimate: 0h
            Time Spent: 10m

> Ensure Helix workflows are cleaned up on cluster start up in centralized mode
> -----------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1352
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1352
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-cluster
>    Affects Versions: 0.16.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Hung Tran
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As part of the changes introduced in GOBBLIN-1319, the Helix workflow names were modified to include a special prefix. However, this prefix is intended for use in distributed mode. As a consequence of this change, the workflows are no longer being cleaned up on cluster start up leading to a leak in Znodes. Further, since the workflows are left in the START state, the Yarn autoscaling manager requests more containers than needed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)