You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jackson-xky (via GitHub)" <gi...@apache.org> on 2023/09/15 11:40:52 UTC
[GitHub] [flink-connector-hbase] Jackson-xky opened a new pull request, #20: fix: Fix problem due to HBaseRowDataLookupFunction returned to reuse objects
Jackson-xky opened a new pull request, #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20
HBaseRowDataLookupFunction.lookup中返回的结果是Collections.singletonList(serde.convertToNewRow(result))，这里默认都是用convertToNewRow方法，内部是在复用同一个对象，当开启了lookup.cache的时候，会导致缓存的结果只都是同一个对象，从而导致结果错乱，由于这里目前不能判断是否使用cache，因此只能默认使用convertToNewRow返回一个新对象来避免上面的情况
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #20: Fix problem due to HBaseRowDataLookupFunction returned to reuse objects
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1738226095
Thank you for your contribution! Would you mind creating a bug jira with a description about the bug and then modify this PR with that ticket number and also an English description? Thank you in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2074636836
@Tan-JiaLiang I think it is okay to take over. We can keep the separate commits, so the original change will keep its author, even the commit msg can be modified while the original author remains the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Posted by "Tan-JiaLiang (via GitHub)" <gi...@apache.org>.
Tan-JiaLiang commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2066268025
@Jackson-xky This is a serious problem in the hbase lookup join. Are you still working on it? I'd be happy to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Posted by "Tan-JiaLiang (via GitHub)" <gi...@apache.org>.
Tan-JiaLiang commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-2073877197
@MartijnVisser @ferenc-csaky It doesn't look like he's had time to deal with the problem, and I'd like to take it on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Posted by "Jackson-xky (via GitHub)" <gi...@apache.org>.
Jackson-xky commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1763957874
HBaseRowDataLookupFunction. The returned result is the Collections in the lookup. SingletonList (serde. ConvertToNewRow (result). The default convertToNewRow method is used here, and the same object is reused internally. When lookup.cache is enabled, the cache results will only be the same object, resulting in confusion. You can avoid this by default by using convertToNewRow to return a new object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #20: fix: Fix problem due to HBaseRowDataLookupFunction returned to reuse objects
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1721135204
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem due to HBaseRowDataLookupFunction returned to reuse objects [flink-connector-hbase]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #20:
URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1807900127
@ferenc-csaky WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org