[GitHub] [incubator-superset] hongbosong commented on a change in pull request #8586: Fix async queries with SQLLAB_BACKEND_PERSISTENCE

[GitBox <gi...@apache.org>]

hongbosong commented on a change in pull request #8586: Fix async queries with SQLLAB_BACKEND_PERSISTENCE
URL: https://github.com/apache/incubator-superset/pull/8586#discussion_r346954115
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/SouthPane.jsx
 ##########
 @@ -92,6 +92,7 @@ export class SouthPane extends React.PureComponent {
     if (latestQuery) {
       if (
         isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE) &&
+        latestQuery.state === 'success' &&
 
 Review comment:
   Nit: might want to create a enum or put the state in some centralized place instead of hard coding :). I have no idea what are the valid query states 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org