[GitHub] [incubator-pagespeed-mod] Lofesa edited a comment on issue #2046: URL sent as a parameter to the CriticalImages.Run seems to be incorrect when Pagespeed is running behind proxy

[GitBox <gi...@apache.org>]

Lofesa edited a comment on issue #2046:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2046#issuecomment-719497424


   > 
   > Not sure what you think by `is only for the add_instrumentation filter....` since here it is exactly the same code:
   >
    
   I think that because in the docs ModPagespeedBeaconUrl is only in the add_instrumentation filter, not in critical images or critical css
   
   > https://github.com/apache/incubator-pagespeed-mod/blob/b0edead4c1e7c834f68ceb66dbfb478533a5c8af/net/instaweb/rewriter/add_instrumentation_filter.cc#L224
   
   Now I catch what the issue is... I think. Is not the url for the beacon him self rather than the url that the beacon has in their payload. Rigth?  Some like:
   
   `https://example.com/ngx_pagespeed_beacon?url=https%3A%2F%2Finternal.example.com%2F`
   
   If that is the issue, I think that is rigth to have external.example.com in these url because in the pagespeed cache, optimized resources are stored with these url as part of the cache keys.
   In this:
   
   user request (https://example.com/) --> proxy (https://internal.example.com)  --> origin server
   
   beacon need to update the pagespeed cache info for that page (https://internal.example.com) and don´t know nothing about  (https://example.com/).
   
   But maybe I´m wrong here, maybe @jmarantz can tell some words for this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org