You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/14 08:34:48 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2602: [Enhancement] Method creates local variable-based synchronized collection

Alonexc opened a new issue, #2602:
URL: https://github.com/apache/incubator-eventmesh/issues/2602

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/207545419-3cf0394b-56fe-44ed-b1be-91449adcae03.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/ShowClientBySystemHandler.java line 61
   analysis and explanation:
   This method creates a synchronized collection and stores the reference to it in a local variable. As local variables are by definition thread-safe, it seems questionable that this collection needs to be synchronized.
   
   
   ### Describe the solution you'd like
   
   reference:
   ![image](https://user-images.githubusercontent.com/91315508/207545347-9dc8b9cd-ca23-4ad4-96d8-4caea6650351.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] jonyangx closed issue #2602: [Enhancement] Method creates local variable-based synchronized collection

Posted by GitBox <gi...@apache.org>.

jonyangx closed issue #2602: [Enhancement]  Method creates local variable-based synchronized collection
URL: https://github.com/apache/incubator-eventmesh/issues/2602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org