You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/27 07:22:41 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10264: [Feature-9385][docs] Added Local File Resource Configuration Guide to the document

SbloodyS commented on code in PR #10264:
URL: https://github.com/apache/dolphinscheduler/pull/10264#discussion_r883346274


##########
docs/docs/en/guide/resource/configuration.md:
##########
@@ -2,13 +2,23 @@
 
 The Resource Center is usually used for operations such as uploading files, UDF functions, and task group management. You can appoint the local file directory as the upload directory for a single machine (this operation does not need to deploy Hadoop). Or you can also upload to a Hadoop or MinIO cluster, at this time, you need to have Hadoop (2.6+) or MinIO or other related environments.
 
+## Local File Resource Configuration
+For a single machine, you can choose to use local file directory as the upload directory (no need to deploy Hadoop) by making the following configuration.
+
+### Configuring the common.properties
+
+Configure the file in the following paths: `api-server/conf/common.properties` and `worker-server/conf/common.properties`.
+
+- Change 'data.basedir.path' to the local directory path. Please make sure the directory exists and have read write permissions, such as: `data.basedir.path=C:/tmp/dolphinscheduler`.
+- Modify two fields, `resource.storage.type=HDFS` and `fs.defaultFS=file:///`.

Review Comment:
   Is it better to use ```Modify the following two parameters```?



##########
docs/docs/zh/guide/resource/configuration.md:
##########
@@ -2,6 +2,16 @@
 
 资源中心通常用于上传文件、 UDF 函数,以及任务组管理等操作。针对单机环境可以选择本地文件目录作为上传文件夹(此操作不需要部署 Hadoop)。当然也可以选择上传到 Hadoop or MinIO 集群上,此时则需要有 Hadoop(2.6+)或者 MinIOn 等相关环境。
 
+## 本地资源配置
+在单机环境下,可以选择使用本地文件目录作为上传文件夹(无需部署Hadoop),此时需要进行如下配置:
+
+### 配置 common.properties 文件
+
+对以下路径的文件进行配置:`api-server/conf/common.properties` 和 `worker-server/conf/common.properties`
+
+- 将`data.basedir.path`改为本地存储路径,请确保路径存在并拥有读写权限,例如:`data.basedir.path=C:/tmp/dolphinscheduler`

Review Comment:
   Same as english's doc.



##########
docs/docs/en/guide/resource/configuration.md:
##########
@@ -2,13 +2,23 @@
 
 The Resource Center is usually used for operations such as uploading files, UDF functions, and task group management. You can appoint the local file directory as the upload directory for a single machine (this operation does not need to deploy Hadoop). Or you can also upload to a Hadoop or MinIO cluster, at this time, you need to have Hadoop (2.6+) or MinIO or other related environments.
 
+## Local File Resource Configuration
+For a single machine, you can choose to use local file directory as the upload directory (no need to deploy Hadoop) by making the following configuration.
+
+### Configuring the common.properties
+
+Configure the file in the following paths: `api-server/conf/common.properties` and `worker-server/conf/common.properties`.
+
+- Change 'data.basedir.path' to the local directory path. Please make sure the directory exists and have read write permissions, such as: `data.basedir.path=C:/tmp/dolphinscheduler`.

Review Comment:
   It's recommanded use it to describe ``Change `data.basedir.path` to the local directory path. Please make sure the directory exists and the user who deploy dolphinscheduler have read and write permissions. For example `data.basedir.path=/tmp/dolphinscheduler` ``.



##########
docs/docs/zh/guide/resource/configuration.md:
##########
@@ -2,6 +2,16 @@
 
 资源中心通常用于上传文件、 UDF 函数,以及任务组管理等操作。针对单机环境可以选择本地文件目录作为上传文件夹(此操作不需要部署 Hadoop)。当然也可以选择上传到 Hadoop or MinIO 集群上,此时则需要有 Hadoop(2.6+)或者 MinIOn 等相关环境。
 
+## 本地资源配置
+在单机环境下,可以选择使用本地文件目录作为上传文件夹(无需部署Hadoop),此时需要进行如下配置:
+
+### 配置 common.properties 文件
+
+对以下路径的文件进行配置:`api-server/conf/common.properties` 和 `worker-server/conf/common.properties`
+
+- 将`data.basedir.path`改为本地存储路径,请确保路径存在并拥有读写权限,例如:`data.basedir.path=C:/tmp/dolphinscheduler`
+- 修改两个字段,分别是`resource.storage.type=HDFS`和`fs.defaultFS=file:///`。

Review Comment:
   Same as english's doc.



##########
docs/docs/en/guide/resource/configuration.md:
##########
@@ -2,13 +2,23 @@
 
 The Resource Center is usually used for operations such as uploading files, UDF functions, and task group management. You can appoint the local file directory as the upload directory for a single machine (this operation does not need to deploy Hadoop). Or you can also upload to a Hadoop or MinIO cluster, at this time, you need to have Hadoop (2.6+) or MinIO or other related environments.
 
+## Local File Resource Configuration
+For a single machine, you can choose to use local file directory as the upload directory (no need to deploy Hadoop) by making the following configuration.
+
+### Configuring the common.properties
+
+Configure the file in the following paths: `api-server/conf/common.properties` and `worker-server/conf/common.properties`.
+
+- Change 'data.basedir.path' to the local directory path. Please make sure the directory exists and have read write permissions, such as: `data.basedir.path=C:/tmp/dolphinscheduler`.
+- Modify two fields, `resource.storage.type=HDFS` and `fs.defaultFS=file:///`.
+
 ## HDFS Resource Configuration
 
 When it is necessary to use the Resource Center to create or upload relevant files, all files and resources will be stored on HDFS. Therefore the following configuration is required.
 
 ### Configuring the common.properties
 
-After version 3.0.0-alpha, if you want to upload resources using HDFS or S3 from the Resource Center, you will need to configure the following paths The following paths need to be configured: `api-server/conf/common.properties` and `worker-server/conf/common.properties`. This can be found as follows.
+After version 3.0.0-alpha, if you want to upload resources using HDFS or S3 from the Resource Center, you will need to configure the following paths: `api-server/conf/common.properties` and `worker-server/conf/common.properties`. This can be found as follows.

Review Comment:
   I think we should keep it as it is which is more accurate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org