You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@lucene.apache.org by Andi Vajda <va...@apache.org> on 2017/03/27 22:12:48 UTC
[VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
The PyLucene 6.5.0 (rc1) release tracking today's release of
Apache Lucene 6.5.0 is ready.
A release candidate is available from:
https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
PyLucene 6.5.0 is built with JCC 3.0 included in these release artifacts.
JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
PyLucene may be built with Python 2 or Python 3.
Please vote to release these artifacts as PyLucene 6.5.0.
Anyone interested in this release can and should vote !
Thanks !
Andi..
ps: the KEYS file for PyLucene release signing is at:
https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
pps: here is my +1
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Ruediger Meier <sw...@gmx.de>.
On Wednesday 29 March 2017, Petrus Hyvönen wrote:
> Hi,
>
> Yes, there are windows users :)
>
> I've ran a quick test, it builds fine on python 2.7 but I'm getting
> some linker error under python 3.6 and 3.5 (didn't try lower).
>
> The linker error states:
>
> jcc3/sources/jcc.cpp(202): error C3688: invalid literal suffix
> 'PRIxMAX'; literal operator or literal operator template
> 'operator ""PRIxMAX' not found
> jcc3/sources/jcc.cpp(202): error C2664: 'int sprintf(char *const
> ,const char *const ,...)': cannot convert argument 2 fr
> om 'int' to 'const char *const '
> jcc3/sources/jcc.cpp(202): note: Conversion from integral type to
> pointer type requires reinterpret_cast, C-style cast o
> r function-style cast
> error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio
> 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2
>
> the jcc.cpp code is:
> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
> {
> static const size_t hexdig = sizeof(uintmax_t) * 2;
> uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
> char buffer[hexdig + 1];
>
> sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
> return PyUnicode_FromStringAndSize(buffer, hexdig);
> }
>
> I don't understand the PRIxMAX stuff there, what does it mean?
Could you try to change
sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
to
sprintf(buffer, "%0*%jx", (int) hexdig, hash);
or if it still not works
sprintf(buffer, "%0*%llx", (int) hexdig, (unsigned long long)hash);
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Thu, 30 Mar 2017, R�diger Meier wrote:
>
>
> On 03/30/2017 09:05 PM, Andi Vajda wrote:
>>
>> On Thu, 30 Mar 2017, Petrus HyvC6nen wrote:
>>
>>> Hi,
>>>
>>> My current diff to the svn is below (as in the chain of mails). Now
>>> i get it to wrap my library in both 2.7, 3.5 and 3.6.
>>
>> I believe, I've now applied all these diffs (or equivalents). Thank
>> you Petrus for testing on Windows, I'm going to release rc2 artifacts
>> and call for a new vote.
>
> Just noticed another minor thing needed for python 3.7 support.
There is no Python 3.7 yet, is there ?
Anyhow, I just cut rc2. Next release.
Andi..
>
> jcc3/sources/jcc.cpp, line 485:
>
> - char *option = PyUnicode_AsUTF8(arg);
> + const char *option = PyUnicode_AsUTF8(arg);
>
> cu,
> Rudi
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Rüdiger Meier <sw...@gmx.de>.
On 03/30/2017 09:05 PM, Andi Vajda wrote:
>
> On Thu, 30 Mar 2017, Petrus Hyv�nen wrote:
>
>> Hi,
>>
>> My current diff to the svn is below (as in the chain of mails). Now
>> i get it to wrap my library in both 2.7, 3.5 and 3.6.
>
> I believe, I've now applied all these diffs (or equivalents). Thank
> you Petrus for testing on Windows, I'm going to release rc2 artifacts
> and call for a new vote.
Just noticed another minor thing needed for python 3.7 support.
jcc3/sources/jcc.cpp, line 485:
- char *option = PyUnicode_AsUTF8(arg);
+ const char *option = PyUnicode_AsUTF8(arg);
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Thu, 30 Mar 2017, Petrus Hyv�nen wrote:
> Hi,
>
> My current diff to the svn is below (as in the chain of mails). Now i get
> it to wrap my library in both 2.7, 3.5 and 3.6.
I believe, I've now applied all these diffs (or equivalents).
Thank you Petrus for testing on Windows, I'm going to release rc2 artifacts
and call for a new vote.
Andi..
>
> /Regards
>
>
> Index: jcc2/__init__.py
> ===================================================================
> --- jcc2/__init__.py (revision 1789413)
> +++ jcc2/__init__.py (working copy)
> @@ -20,7 +20,7 @@
> from windows import add_jvm_dll_directory_to_path
> add_jvm_dll_directory_to_path()
>
> - from jcc2.config import SHARED
> + from jcc.config import SHARED
> if SHARED:
> path = os.environ['Path'].split(os.pathsep)
> eggpath =
> os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
> Index: jcc3/sources/functions.cpp
> ===================================================================
> --- jcc3/sources/functions.cpp (revision 1789413)
> +++ jcc3/sources/functions.cpp (working copy)
> @@ -300,7 +300,7 @@
> #if defined(_MSC_VER) || defined(__SUNPRO_CC)
> int __parseArgs(PyObject *args, char *types, ...)
> {
> - int count = PY_SIZE((PyTupleObject *) args);
> + int count = Py_SIZE((PyTupleObject *) args); //WAS PY_SIZE
> va_list list, check;
>
> va_start(list, types);
> Index: jcc3/sources/jcc.cpp
> ===================================================================
> --- jcc3/sources/jcc.cpp (revision 1789413)
> +++ jcc3/sources/jcc.cpp (working copy)
> @@ -195,11 +195,11 @@
>
> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
> {
> - static const size_t hexdig = sizeof(uintmax_t) * 2;
> - uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
> + unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
> + static const size_t hexdig = sizeof(hash) * 2;
> char buffer[hexdig + 1];
>
> - sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
> + sprintf(buffer, "%0*llx", (int) hexdig, hash);
> return PyUnicode_FromStringAndSize(buffer, hexdig);
> }
>
> Index: setup.py
> ===================================================================
> --- setup.py (revision 1789413)
> +++ setup.py (working copy)
> @@ -158,7 +158,7 @@
> 'sunos5': ['-L%(sunos5)s/jre/lib/i386' %(JDK), '-ljava',
> '-L%(sunos5)s/jre/lib/i386/client' %(JDK), '-ljvm',
> '-R%(sunos5)s/jre/lib/i386:%(sunos5)s/jre/lib/i386/client'
> %(JDK)],
> - 'win32': ['/LIBPATH:%(win32)s/lib' %(JDK), 'Ws2_32.lib', 'jvm.lib'],
> + 'win32': ['/LIBPATH:%(win32)s/lib' %(JDK), 'Ws2_32.lib',
> 'jvm.lib','/DLL'],
> 'mingw32': ['-L%(mingw32)s/lib' %(JDK), '-ljvm'],
> 'freebsd7': ['-L%(freebsd7)s/jre/lib/i386' %(JDK), '-ljava',
> '-lverify',
> '-L%(freebsd7)s/jre/lib/i386/client' %(JDK), '-ljvm',
>
>
>
> On Thu, Mar 30, 2017 at 5:36 PM, Petrus Hyv�nen <pe...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I was trying the python 2.7 build and I think the line 23 in
>> jcc2/__init__.py should be:
>>
>> from jcc.config import SHARED
>>
>> (instead of from jcc2.config import..)
>>
>> Regards
>> /Petrus
>>
>>
>> On Thu, Mar 30, 2017 at 9:10 AM, Petrus Hyv�nen <pe...@gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> With this version of of t_jccenv_strhash I can build both JCC and wrap
>>> the library I'm using!
>>>
>>> Regards
>>> /Petrus
>>>
>>>
>>>
>>>>
>>>>
>>>>> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
>>>>> {
>>>>> unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
>>>>> static const size_t hexdig = sizeof(hash) * 2;
>>>>> char buffer[hexdig + 1];
>>>>>
>>>>> sprintf(buffer, "%0*llx", (int) hexdig, hash);
>>>>> return PyUnicode_FromStringAndSize(buffer, hexdig);
>>>>> }
>>>>>
>>>>> BTW this function should be also copied to the py2 directory where we
>>>>> still use int allthough PyObject_Hash returns already long on python
>>>>>
>>>>>> 2.x.
>>>>>>
>>>>>
>>>>> cu,
>>>>> Rudi
>>>>>
>>>>>
>>>>>
>>>
>>>
>>> --
>>> _____________________________________________
>>> Petrus Hyv�nen, Uppsala, Sweden
>>> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>>>
>>
>>
>>
>> --
>> _____________________________________________
>> Petrus Hyv�nen, Uppsala, Sweden
>> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>>
>
>
>
> --
> _____________________________________________
> Petrus Hyv�nen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
My current diff to the svn is below (as in the chain of mails). Now i get
it to wrap my library in both 2.7, 3.5 and 3.6.
/Regards
Index: jcc2/__init__.py
===================================================================
--- jcc2/__init__.py (revision 1789413)
+++ jcc2/__init__.py (working copy)
@@ -20,7 +20,7 @@
from windows import add_jvm_dll_directory_to_path
add_jvm_dll_directory_to_path()
- from jcc2.config import SHARED
+ from jcc.config import SHARED
if SHARED:
path = os.environ['Path'].split(os.pathsep)
eggpath =
os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
Index: jcc3/sources/functions.cpp
===================================================================
--- jcc3/sources/functions.cpp (revision 1789413)
+++ jcc3/sources/functions.cpp (working copy)
@@ -300,7 +300,7 @@
#if defined(_MSC_VER) || defined(__SUNPRO_CC)
int __parseArgs(PyObject *args, char *types, ...)
{
- int count = PY_SIZE((PyTupleObject *) args);
+ int count = Py_SIZE((PyTupleObject *) args); //WAS PY_SIZE
va_list list, check;
va_start(list, types);
Index: jcc3/sources/jcc.cpp
===================================================================
--- jcc3/sources/jcc.cpp (revision 1789413)
+++ jcc3/sources/jcc.cpp (working copy)
@@ -195,11 +195,11 @@
static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
{
- static const size_t hexdig = sizeof(uintmax_t) * 2;
- uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
+ unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
+ static const size_t hexdig = sizeof(hash) * 2;
char buffer[hexdig + 1];
- sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
+ sprintf(buffer, "%0*llx", (int) hexdig, hash);
return PyUnicode_FromStringAndSize(buffer, hexdig);
}
Index: setup.py
===================================================================
--- setup.py (revision 1789413)
+++ setup.py (working copy)
@@ -158,7 +158,7 @@
'sunos5': ['-L%(sunos5)s/jre/lib/i386' %(JDK), '-ljava',
'-L%(sunos5)s/jre/lib/i386/client' %(JDK), '-ljvm',
'-R%(sunos5)s/jre/lib/i386:%(sunos5)s/jre/lib/i386/client'
%(JDK)],
- 'win32': ['/LIBPATH:%(win32)s/lib' %(JDK), 'Ws2_32.lib', 'jvm.lib'],
+ 'win32': ['/LIBPATH:%(win32)s/lib' %(JDK), 'Ws2_32.lib',
'jvm.lib','/DLL'],
'mingw32': ['-L%(mingw32)s/lib' %(JDK), '-ljvm'],
'freebsd7': ['-L%(freebsd7)s/jre/lib/i386' %(JDK), '-ljava',
'-lverify',
'-L%(freebsd7)s/jre/lib/i386/client' %(JDK), '-ljvm',
On Thu, Mar 30, 2017 at 5:36 PM, Petrus Hyvönen <pe...@gmail.com>
wrote:
> Hi,
>
> I was trying the python 2.7 build and I think the line 23 in
> jcc2/__init__.py should be:
>
> from jcc.config import SHARED
>
> (instead of from jcc2.config import..)
>
> Regards
> /Petrus
>
>
> On Thu, Mar 30, 2017 at 9:10 AM, Petrus Hyvönen <pe...@gmail.com>
> wrote:
>
>> Hi,
>>
>> With this version of of t_jccenv_strhash I can build both JCC and wrap
>> the library I'm using!
>>
>> Regards
>> /Petrus
>>
>>
>>
>>>
>>>
>>>> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
>>>> {
>>>> unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
>>>> static const size_t hexdig = sizeof(hash) * 2;
>>>> char buffer[hexdig + 1];
>>>>
>>>> sprintf(buffer, "%0*llx", (int) hexdig, hash);
>>>> return PyUnicode_FromStringAndSize(buffer, hexdig);
>>>> }
>>>>
>>>> BTW this function should be also copied to the py2 directory where we
>>>> still use int allthough PyObject_Hash returns already long on python
>>>>
>>>>> 2.x.
>>>>>
>>>>
>>>> cu,
>>>> Rudi
>>>>
>>>>
>>>>
>>
>>
>> --
>> _____________________________________________
>> Petrus Hyvönen, Uppsala, Sweden
>> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>>
>
>
>
> --
> _____________________________________________
> Petrus Hyvönen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
I was trying the python 2.7 build and I think the line 23 in
jcc2/__init__.py should be:
from jcc.config import SHARED
(instead of from jcc2.config import..)
Regards
/Petrus
On Thu, Mar 30, 2017 at 9:10 AM, Petrus Hyvönen <pe...@gmail.com>
wrote:
> Hi,
>
> With this version of of t_jccenv_strhash I can build both JCC and wrap the
> library I'm using!
>
> Regards
> /Petrus
>
>
>
>>
>>
>>> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
>>> {
>>> unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
>>> static const size_t hexdig = sizeof(hash) * 2;
>>> char buffer[hexdig + 1];
>>>
>>> sprintf(buffer, "%0*llx", (int) hexdig, hash);
>>> return PyUnicode_FromStringAndSize(buffer, hexdig);
>>> }
>>>
>>> BTW this function should be also copied to the py2 directory where we
>>> still use int allthough PyObject_Hash returns already long on python
>>>
>>>> 2.x.
>>>>
>>>
>>> cu,
>>> Rudi
>>>
>>>
>>>
>
>
> --
> _____________________________________________
> Petrus Hyvönen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
With this version of of t_jccenv_strhash I can build both JCC and wrap the
library I'm using!
Regards
/Petrus
>
>
>> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
>> {
>> unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
>> static const size_t hexdig = sizeof(hash) * 2;
>> char buffer[hexdig + 1];
>>
>> sprintf(buffer, "%0*llx", (int) hexdig, hash);
>> return PyUnicode_FromStringAndSize(buffer, hexdig);
>> }
>>
>> BTW this function should be also copied to the py2 directory where we
>> still use int allthough PyObject_Hash returns already long on python
>>
>>> 2.x.
>>>
>>
>> cu,
>> Rudi
>>
>>
>>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Thu, 30 Mar 2017, Ruediger Meier wrote:
> On Wednesday 29 March 2017, Andi Vajda wrote:
>> On Wed, 29 Mar 2017, Petrus Hyv�nen wrote:
>>> Hi,
>>>
>>> With the /DLL, sprintf(buffer, "%0*%jx", (int) hexdig, hash); and
>>> Py_SIZE it compiles under windows (Windows 7, 64 bit)
>>>
>>> I haven't set up for building pylucene but has another library that
>>> I build.
>>>
>>> For that I get a udf-8 error on:
>>>
>>> File
>>> "C:\Users\phy\AppData\Local\Continuum\Anaconda3-430\conda-bld\oreki
>>> t_1490824040916\_b_env\lib\site-packages\jcc\c pp.py", line 898, in
>>> header
>>> env.strhash(signature(constructor)))
>>> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in
>>> position 9: invalid start byte
>>
>> That means that the "%0*%jx" change for _MSC_VER also needs a change
>> for the hexdig sizeof computation. There is a mismatch and garbage is
>> left in the buffer array.
>
>
> Hm, actually "%jx" and PRIxMAX should be equivalent modifiers to print
> uintmax_t (c99). According to the MSC documentation I thought that the
> macro is even more safe to use.
>
> The problem is that we do C++ here which does not need to support c99 at
> all. Though MSC might be the only C++ compiler which ignores c99...
>
> To fix it I would suggest to use non-c99 types here. Lets use "unsigned
> long long" and "%llx". This may look a bit less rock-solid but good
> enough for any existing systems:
I'm happy to hide this _MSC_VER hackery in conditional code.
Andi..
>
> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
> {
> unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
> static const size_t hexdig = sizeof(hash) * 2;
> char buffer[hexdig + 1];
>
> sprintf(buffer, "%0*llx", (int) hexdig, hash);
> return PyUnicode_FromStringAndSize(buffer, hexdig);
> }
>
> BTW this function should be also copied to the py2 directory where we
> still use int allthough PyObject_Hash returns already long on python
>> 2.x.
>
> cu,
> Rudi
>
>
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Ruediger Meier <sw...@gmx.de>.
On Wednesday 29 March 2017, Andi Vajda wrote:
> On Wed, 29 Mar 2017, Petrus Hyvönen wrote:
> > Hi,
> >
> > With the /DLL, sprintf(buffer, "%0*%jx", (int) hexdig, hash); and
> > Py_SIZE it compiles under windows (Windows 7, 64 bit)
> >
> > I haven't set up for building pylucene but has another library that
> > I build.
> >
> > For that I get a udf-8 error on:
> >
> > File
> > "C:\Users\phy\AppData\Local\Continuum\Anaconda3-430\conda-bld\oreki
> >t_1490824040916\_b_env\lib\site-packages\jcc\c pp.py", line 898, in
> > header
> > env.strhash(signature(constructor)))
> > UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in
> > position 9: invalid start byte
>
> That means that the "%0*%jx" change for _MSC_VER also needs a change
> for the hexdig sizeof computation. There is a mismatch and garbage is
> left in the buffer array.
Hm, actually "%jx" and PRIxMAX should be equivalent modifiers to print
uintmax_t (c99). According to the MSC documentation I thought that the
macro is even more safe to use.
The problem is that we do C++ here which does not need to support c99 at
all. Though MSC might be the only C++ compiler which ignores c99...
To fix it I would suggest to use non-c99 types here. Lets use "unsigned
long long" and "%llx". This may look a bit less rock-solid but good
enough for any existing systems:
static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
{
unsigned long long hash = (unsigned long long) PyObject_Hash(arg);
static const size_t hexdig = sizeof(hash) * 2;
char buffer[hexdig + 1];
sprintf(buffer, "%0*llx", (int) hexdig, hash);
return PyUnicode_FromStringAndSize(buffer, hexdig);
}
BTW this function should be also copied to the py2 directory where we
still use int allthough PyObject_Hash returns already long on python
>2.x.
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Wed, 29 Mar 2017, Petrus Hyv�nen wrote:
> Hi,
>
> With the /DLL, sprintf(buffer, "%0*%jx", (int) hexdig, hash); and Py_SIZE
> it compiles under windows (Windows 7, 64 bit)
>
> I haven't set up for building pylucene but has another library that I build.
>
> For that I get a udf-8 error on:
>
> File
> "C:\Users\phy\AppData\Local\Continuum\Anaconda3-430\conda-bld\orekit_1490824040916\_b_env\lib\site-packages\jcc\c
> pp.py", line 898, in header
> env.strhash(signature(constructor)))
> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in position 9:
> invalid start byte
That means that the "%0*%jx" change for _MSC_VER also needs a change for the
hexdig sizeof computation. There is a mismatch and garbage is left in the
buffer array.
Andi..
>
> I will do more tests later, and see if I can test with building pylucene.
>
> Regards
> /Petrus
>
>
>
> On Wed, Mar 29, 2017 at 11:26 PM, Ruediger Meier <sw...@gmx.de> wrote:
>
>> On Wednesday 29 March 2017, Petrus Hyv�nen wrote:
>>> Hi,
>>>
>>> Assuming the Prixmax stuff is just some typo, if I remove that I get
>>> same error as in Ruedigers github version - MS linker error LNK1561 -
>>> missing starting point. This seems to be fixed by the /DLL
>>> directive.
>>>
>>> https://msdn.microsoft.com/en-us/library/ky737ya4.aspx
>>>
>>> and fix at
>>> https://github.com/rudimeier/jcc/issues/1
>>>
>>> Adding this /DLL to the linker options, I now get linker error:
>>> "jcc3/sources/functions.cpp(303): error C3861: 'PY_SIZE': identifier
>>> not found"
>>>
>>> The code is:
>>> 301 int __parseArgs(PyObject *args, char *types, ...)
>>> 302 {
>>> 303: int count = PY_SIZE((PyTupleObject *) args);
>>> 304 va_list list, check;
>>> 305
>>
>> Probably just a typo, try "Py_SIZE" (case sensitive "y").
>>
>> cu,
>> Rudi
>>
>
>
>
> --
> _____________________________________________
> Petrus Hyv�nen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
With the /DLL, sprintf(buffer, "%0*%jx", (int) hexdig, hash); and Py_SIZE
it compiles under windows (Windows 7, 64 bit)
I haven't set up for building pylucene but has another library that I build.
For that I get a udf-8 error on:
File
"C:\Users\phy\AppData\Local\Continuum\Anaconda3-430\conda-bld\orekit_1490824040916\_b_env\lib\site-packages\jcc\c
pp.py", line 898, in header
env.strhash(signature(constructor)))
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in position 9:
invalid start byte
I will do more tests later, and see if I can test with building pylucene.
Regards
/Petrus
On Wed, Mar 29, 2017 at 11:26 PM, Ruediger Meier <sw...@gmx.de> wrote:
> On Wednesday 29 March 2017, Petrus Hyvönen wrote:
> > Hi,
> >
> > Assuming the Prixmax stuff is just some typo, if I remove that I get
> > same error as in Ruedigers github version - MS linker error LNK1561 -
> > missing starting point. This seems to be fixed by the /DLL
> > directive.
> >
> > https://msdn.microsoft.com/en-us/library/ky737ya4.aspx
> >
> > and fix at
> > https://github.com/rudimeier/jcc/issues/1
> >
> > Adding this /DLL to the linker options, I now get linker error:
> > "jcc3/sources/functions.cpp(303): error C3861: 'PY_SIZE': identifier
> > not found"
> >
> > The code is:
> > 301 int __parseArgs(PyObject *args, char *types, ...)
> > 302 {
> > 303: int count = PY_SIZE((PyTupleObject *) args);
> > 304 va_list list, check;
> > 305
>
> Probably just a typo, try "Py_SIZE" (case sensitive "y").
>
> cu,
> Rudi
>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Ruediger Meier <sw...@gmx.de>.
On Wednesday 29 March 2017, Petrus Hyvönen wrote:
> Hi,
>
> Assuming the Prixmax stuff is just some typo, if I remove that I get
> same error as in Ruedigers github version - MS linker error LNK1561 -
> missing starting point. This seems to be fixed by the /DLL
> directive.
>
> https://msdn.microsoft.com/en-us/library/ky737ya4.aspx
>
> and fix at
> https://github.com/rudimeier/jcc/issues/1
>
> Adding this /DLL to the linker options, I now get linker error:
> "jcc3/sources/functions.cpp(303): error C3861: 'PY_SIZE': identifier
> not found"
>
> The code is:
> 301 int __parseArgs(PyObject *args, char *types, ...)
> 302 {
> 303: int count = PY_SIZE((PyTupleObject *) args);
> 304 va_list list, check;
> 305
Probably just a typo, try "Py_SIZE" (case sensitive "y").
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Wed, 29 Mar 2017, Petrus Hyvnen wrote:
> Hi,
>
> Assuming the Prixmax stuff is just some typo, if I remove that I get same
> error as in Ruedigers github version - MS linker error LNK1561 - missing
> starting point. This seems to be fixed by the /DLL directive.
>
> https://msdn.microsoft.com/en-us/library/ky737ya4.aspx
>
> and fix at
> https://github.com/rudimeier/jcc/issues/1
>
> Adding this /DLL to the linker options, I now get linker error:
> "jcc3/sources/functions.cpp(303): error C3861: 'PY_SIZE': identifier not
> found"
>
> The code is:
> 301 int __parseArgs(PyObject *args, char *types, ...)
> 302 {
> 303: int count = PY_SIZE((PyTupleObject *) args);
Ooop, that should be Py_SIZE. Fixed now.
Andi..
> 304 va_list list, check;
> 305
>
> The other stuff related to size i find is using the PyBytes_Size(arg)?
>
> Again, many thanks :)
>
> Best Regards
> /Petrus
>
>
>
>
> On Wed, Mar 29, 2017 at 10:52 PM, Petrus Hyvnen <pe...@gmail.com>
> wrote:
>
>> Hi,
>>
>> Yes, there are windows users :)
>>
>> I've ran a quick test, it builds fine on python 2.7 but I'm getting some
>> linker error under python 3.6 and 3.5 (didn't try lower).
>>
>> The linker error states:
>>
>> jcc3/sources/jcc.cpp(202): error C3688: invalid literal suffix 'PRIxMAX';
>> literal operator or literal operator template
>> 'operator ""PRIxMAX' not found
>> jcc3/sources/jcc.cpp(202): error C2664: 'int sprintf(char *const ,const
>> char *const ,...)': cannot convert argument 2 fr
>> om 'int' to 'const char *const '
>> jcc3/sources/jcc.cpp(202): note: Conversion from integral type to pointer
>> type requires reinterpret_cast, C-style cast o
>> r function-style cast
>> error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio
>> 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2
>>
>> the jcc.cpp code is:
>> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
>> {
>> static const size_t hexdig = sizeof(uintmax_t) * 2;
>> uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
>> char buffer[hexdig + 1];
>>
>> sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
>> return PyUnicode_FromStringAndSize(buffer, hexdig);
>> }
>>
>> I don't understand the PRIxMAX stuff there, what does it mean?
>>
>> MANY thanks for working with the Python 3 port...
>>
>> Regards
>> /Petrus
>>
>>
>> On Wed, Mar 29, 2017 at 10:43 PM, Andi Vajda <va...@apache.org> wrote:
>>
>>>
>>>> On Mar 29, 2017, at 13:36, Ruediger Meier <sw...@gmx.de> wrote:
>>>>
>>>> On Wednesday 29 March 2017, Andi Vajda wrote:
>>>>
>>>>>> Regarding that release candidate. There are still one or two minor
>>>>>> issues on Linux
>>>>>
>>>>> I'm aware of the fsct that the -lpython... link line for shared mode
>>>>> on linux needs editing depending on the versions of python used. Are
>>>>> there other issues on linux ?
>>>>
>>>> No other issues. I've fixed -lpython for myself like this
>>>> https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b
>>> 7635160f798303715877
>>>>
>>>> but you probably want do avoid the .so version earlier like you did for
>>>> OSX. You may fix it blindly as you prefer and I could test it.
>>>>
>>>>>> and Windows I think. I will test again and report soon.
>>>>>
>>>>> I have no access to windows anymore. We (Apache committers) used to
>>>>> get a MSDN free subscription but that program was apparently
>>>>> discontinued. If you have access to windows, thank you for trying out
>>>>> PyLucene and JCC there !
>>>>
>>>> I could somehow organize a windows for testing, though it would be
>>>> painful for me. ;) I would do it shortly before final release if nobody
>>>> else does it.
>>>
>>> Don't bother. If there are no windows users willing to test this then we
>>> don't need to support windows anymore.
>>>
>>>> So far I believe that the patch here in my last comment would do it
>>>> https://github.com/rudimeier/jcc/issues/1
>>>> (It was also part of tommykoch's port)
>>>
>>> Ok, I'll take another look...
>>>
>>> Andi..
>>>
>>>>
>>>> cu,
>>>> Rudi
>>>
>>>
>>
>>
>> --
>> _____________________________________________
>> Petrus Hyvnen, Uppsala, Sweden
>> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>>
>
>
>
> --
> _____________________________________________
> Petrus Hyvnen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
Assuming the Prixmax stuff is just some typo, if I remove that I get same
error as in Ruedigers github version - MS linker error LNK1561 - missing
starting point. This seems to be fixed by the /DLL directive.
https://msdn.microsoft.com/en-us/library/ky737ya4.aspx
and fix at
https://github.com/rudimeier/jcc/issues/1
Adding this /DLL to the linker options, I now get linker error:
"jcc3/sources/functions.cpp(303): error C3861: 'PY_SIZE': identifier not
found"
The code is:
301 int __parseArgs(PyObject *args, char *types, ...)
302 {
303: int count = PY_SIZE((PyTupleObject *) args);
304 va_list list, check;
305
The other stuff related to size i find is using the PyBytes_Size(arg)?
Again, many thanks :)
Best Regards
/Petrus
On Wed, Mar 29, 2017 at 10:52 PM, Petrus Hyvönen <pe...@gmail.com>
wrote:
> Hi,
>
> Yes, there are windows users :)
>
> I've ran a quick test, it builds fine on python 2.7 but I'm getting some
> linker error under python 3.6 and 3.5 (didn't try lower).
>
> The linker error states:
>
> jcc3/sources/jcc.cpp(202): error C3688: invalid literal suffix 'PRIxMAX';
> literal operator or literal operator template
> 'operator ""PRIxMAX' not found
> jcc3/sources/jcc.cpp(202): error C2664: 'int sprintf(char *const ,const
> char *const ,...)': cannot convert argument 2 fr
> om 'int' to 'const char *const '
> jcc3/sources/jcc.cpp(202): note: Conversion from integral type to pointer
> type requires reinterpret_cast, C-style cast o
> r function-style cast
> error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio
> 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2
>
> the jcc.cpp code is:
> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
> {
> static const size_t hexdig = sizeof(uintmax_t) * 2;
> uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
> char buffer[hexdig + 1];
>
> sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
> return PyUnicode_FromStringAndSize(buffer, hexdig);
> }
>
> I don't understand the PRIxMAX stuff there, what does it mean?
>
> MANY thanks for working with the Python 3 port...
>
> Regards
> /Petrus
>
>
> On Wed, Mar 29, 2017 at 10:43 PM, Andi Vajda <va...@apache.org> wrote:
>
>>
>> > On Mar 29, 2017, at 13:36, Ruediger Meier <sw...@gmx.de> wrote:
>> >
>> > On Wednesday 29 March 2017, Andi Vajda wrote:
>> >
>> >>> Regarding that release candidate. There are still one or two minor
>> >>> issues on Linux
>> >>
>> >> I'm aware of the fsct that the -lpython... link line for shared mode
>> >> on linux needs editing depending on the versions of python used. Are
>> >> there other issues on linux ?
>> >
>> > No other issues. I've fixed -lpython for myself like this
>> > https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b
>> 7635160f798303715877
>> >
>> > but you probably want do avoid the .so version earlier like you did for
>> > OSX. You may fix it blindly as you prefer and I could test it.
>> >
>> >>> and Windows I think. I will test again and report soon.
>> >>
>> >> I have no access to windows anymore. We (Apache committers) used to
>> >> get a MSDN free subscription but that program was apparently
>> >> discontinued. If you have access to windows, thank you for trying out
>> >> PyLucene and JCC there !
>> >
>> > I could somehow organize a windows for testing, though it would be
>> > painful for me. ;) I would do it shortly before final release if nobody
>> > else does it.
>>
>> Don't bother. If there are no windows users willing to test this then we
>> don't need to support windows anymore.
>>
>> > So far I believe that the patch here in my last comment would do it
>> > https://github.com/rudimeier/jcc/issues/1
>> > (It was also part of tommykoch's port)
>>
>> Ok, I'll take another look...
>>
>> Andi..
>>
>> >
>> > cu,
>> > Rudi
>>
>>
>
>
> --
> _____________________________________________
> Petrus Hyvönen, Uppsala, Sweden
> Mobile Phone/SMS:+46 73 803 19 00 <073-803%2019%2000>
>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Petrus Hyvönen <pe...@gmail.com>.
Hi,
Yes, there are windows users :)
I've ran a quick test, it builds fine on python 2.7 but I'm getting some
linker error under python 3.6 and 3.5 (didn't try lower).
The linker error states:
jcc3/sources/jcc.cpp(202): error C3688: invalid literal suffix 'PRIxMAX';
literal operator or literal operator template
'operator ""PRIxMAX' not found
jcc3/sources/jcc.cpp(202): error C2664: 'int sprintf(char *const ,const
char *const ,...)': cannot convert argument 2 fr
om 'int' to 'const char *const '
jcc3/sources/jcc.cpp(202): note: Conversion from integral type to pointer
type requires reinterpret_cast, C-style cast o
r function-style cast
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio
14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2
the jcc.cpp code is:
static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
{
static const size_t hexdig = sizeof(uintmax_t) * 2;
uintmax_t hash = (uintmax_t) PyObject_Hash(arg);
char buffer[hexdig + 1];
sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
return PyUnicode_FromStringAndSize(buffer, hexdig);
}
I don't understand the PRIxMAX stuff there, what does it mean?
MANY thanks for working with the Python 3 port...
Regards
/Petrus
On Wed, Mar 29, 2017 at 10:43 PM, Andi Vajda <va...@apache.org> wrote:
>
> > On Mar 29, 2017, at 13:36, Ruediger Meier <sw...@gmx.de> wrote:
> >
> > On Wednesday 29 March 2017, Andi Vajda wrote:
> >
> >>> Regarding that release candidate. There are still one or two minor
> >>> issues on Linux
> >>
> >> I'm aware of the fsct that the -lpython... link line for shared mode
> >> on linux needs editing depending on the versions of python used. Are
> >> there other issues on linux ?
> >
> > No other issues. I've fixed -lpython for myself like this
> > https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b7635160f79
> 8303715877
> >
> > but you probably want do avoid the .so version earlier like you did for
> > OSX. You may fix it blindly as you prefer and I could test it.
> >
> >>> and Windows I think. I will test again and report soon.
> >>
> >> I have no access to windows anymore. We (Apache committers) used to
> >> get a MSDN free subscription but that program was apparently
> >> discontinued. If you have access to windows, thank you for trying out
> >> PyLucene and JCC there !
> >
> > I could somehow organize a windows for testing, though it would be
> > painful for me. ;) I would do it shortly before final release if nobody
> > else does it.
>
> Don't bother. If there are no windows users willing to test this then we
> don't need to support windows anymore.
>
> > So far I believe that the patch here in my last comment would do it
> > https://github.com/rudimeier/jcc/issues/1
> > (It was also part of tommykoch's port)
>
> Ok, I'll take another look...
>
> Andi..
>
> >
> > cu,
> > Rudi
>
>
--
_____________________________________________
Petrus Hyvönen, Uppsala, Sweden
Mobile Phone/SMS:+46 73 803 19 00
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Andi Vajda <va...@apache.org>.
> On Mar 29, 2017, at 13:36, Ruediger Meier <sw...@gmx.de> wrote:
>
> On Wednesday 29 March 2017, Andi Vajda wrote:
>
>>> Regarding that release candidate. There are still one or two minor
>>> issues on Linux
>>
>> I'm aware of the fsct that the -lpython... link line for shared mode
>> on linux needs editing depending on the versions of python used. Are
>> there other issues on linux ?
>
> No other issues. I've fixed -lpython for myself like this
> https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b7635160f798303715877
>
> but you probably want do avoid the .so version earlier like you did for
> OSX. You may fix it blindly as you prefer and I could test it.
>
>>> and Windows I think. I will test again and report soon.
>>
>> I have no access to windows anymore. We (Apache committers) used to
>> get a MSDN free subscription but that program was apparently
>> discontinued. If you have access to windows, thank you for trying out
>> PyLucene and JCC there !
>
> I could somehow organize a windows for testing, though it would be
> painful for me. ;) I would do it shortly before final release if nobody
> else does it.
Don't bother. If there are no windows users willing to test this then we don't need to support windows anymore.
> So far I believe that the patch here in my last comment would do it
> https://github.com/rudimeier/jcc/issues/1
> (It was also part of tommykoch's port)
Ok, I'll take another look...
Andi..
>
> cu,
> Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Andi Vajda <va...@apache.org>.
> On Mar 29, 2017, at 13:36, Ruediger Meier <sw...@gmx.de> wrote:
>
> On Wednesday 29 March 2017, Andi Vajda wrote:
>
>>> Regarding that release candidate. There are still one or two minor
>>> issues on Linux
>>
>> I'm aware of the fsct that the -lpython... link line for shared mode
>> on linux needs editing depending on the versions of python used. Are
>> there other issues on linux ?
>
> No other issues. I've fixed -lpython for myself like this
> https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b7635160f798303715877
>
> but you probably want do avoid the .so version earlier like you did for
> OSX. You may fix it blindly as you prefer and I could test it.
>
>>> and Windows I think. I will test again and report soon.
>>
>> I have no access to windows anymore. We (Apache committers) used to
>> get a MSDN free subscription but that program was apparently
>> discontinued. If you have access to windows, thank you for trying out
>> PyLucene and JCC there !
>
> I could somehow organize a windows for testing, though it would be
> painful for me. ;) I would do it shortly before final release if nobody
> else does it.
Don't bother. If there are no windows users willing to test this then we don't need to support windows anymore.
> So far I believe that the patch here in my last comment would do it
> https://github.com/rudimeier/jcc/issues/1
> (It was also part of tommykoch's port)
Ok, I'll take another look...
Andi..
>
> cu,
> Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Ruediger Meier <sw...@gmx.de>.
On Wednesday 29 March 2017, Andi Vajda wrote:
> > Regarding that release candidate. There are still one or two minor
> > issues on Linux
>
> I'm aware of the fsct that the -lpython... link line for shared mode
> on linux needs editing depending on the versions of python used. Are
> there other issues on linux ?
No other issues. I've fixed -lpython for myself like this
https://github.com/rudimeier/jcc/commit/b4a7987ebeeb96d6c71b7635160f798303715877
but you probably want do avoid the .so version earlier like you did for
OSX. You may fix it blindly as you prefer and I could test it.
> > and Windows I think. I will test again and report soon.
>
> I have no access to windows anymore. We (Apache committers) used to
> get a MSDN free subscription but that program was apparently
> discontinued. If you have access to windows, thank you for trying out
> PyLucene and JCC there !
I could somehow organize a windows for testing, though it would be
painful for me. ;) I would do it shortly before final release if nobody
else does it.
So far I believe that the patch here in my last comment would do it
https://github.com/rudimeier/jcc/issues/1
(It was also part of tommykoch's port)
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Andi Vajda <va...@apache.org>.
> On Mar 29, 2017, at 12:11, Ruediger Meier <sw...@gmx.de> wrote:
>
>> On Tuesday 28 March 2017, Andi Vajda wrote:
>> The PyLucene 6.5.0 (rc1) release tracking today's release of
>> Apache Lucene 6.5.0 is ready.
>>
>> A release candidate is available from:
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
>>
>> PyLucene 6.5.0 is built with JCC 3.0 included in these release
>> artifacts.
>>
>> JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
>> PyLucene may be built with Python 2 or Python 3.
>>
>> Please vote to release these artifacts as PyLucene 6.5.0.
>> Anyone interested in this release can and should vote !
>>
>> Thanks !
>>
>> Andi..
>>
>> ps: the KEYS file for PyLucene release signing is at:
>> https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
>>
>> pps: here is my +1
>
> +1
>
> Thanks!
>
> Regarding that release candidate. There are still one or two minor
> issues on Linux
I'm aware of the fsct that the -lpython... link line for shared mode on linux needs editing depending on the versions of python used. Are there other issues on linux ?
> and Windows I think. I will test again and report soon.
I have no access to windows anymore. We (Apache committers) used to get a MSDN free subscription but that program was apparently discontinued. If you have access to windows, thank you for trying out PyLucene and JCC there !
Andi..
>
> cu,
> Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Andi Vajda <va...@apache.org>.
> On Mar 29, 2017, at 12:11, Ruediger Meier <sw...@gmx.de> wrote:
>
>> On Tuesday 28 March 2017, Andi Vajda wrote:
>> The PyLucene 6.5.0 (rc1) release tracking today's release of
>> Apache Lucene 6.5.0 is ready.
>>
>> A release candidate is available from:
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
>>
>> PyLucene 6.5.0 is built with JCC 3.0 included in these release
>> artifacts.
>>
>> JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
>> PyLucene may be built with Python 2 or Python 3.
>>
>> Please vote to release these artifacts as PyLucene 6.5.0.
>> Anyone interested in this release can and should vote !
>>
>> Thanks !
>>
>> Andi..
>>
>> ps: the KEYS file for PyLucene release signing is at:
>> https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
>>
>> pps: here is my +1
>
> +1
>
> Thanks!
>
> Regarding that release candidate. There are still one or two minor
> issues on Linux
I'm aware of the fsct that the -lpython... link line for shared mode on linux needs editing depending on the versions of python used. Are there other issues on linux ?
> and Windows I think. I will test again and report soon.
I have no access to windows anymore. We (Apache committers) used to get a MSDN free subscription but that program was apparently discontinued. If you have access to windows, thank you for trying out PyLucene and JCC there !
Andi..
>
> cu,
> Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Ruediger Meier <sw...@gmx.de>.
On Tuesday 28 March 2017, Andi Vajda wrote:
> The PyLucene 6.5.0 (rc1) release tracking today's release of
> Apache Lucene 6.5.0 is ready.
>
> A release candidate is available from:
> https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
>
> PyLucene 6.5.0 is built with JCC 3.0 included in these release
> artifacts.
>
> JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
> PyLucene may be built with Python 2 or Python 3.
>
> Please vote to release these artifacts as PyLucene 6.5.0.
> Anyone interested in this release can and should vote !
>
> Thanks !
>
> Andi..
>
> ps: the KEYS file for PyLucene release signing is at:
> https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
> https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
>
> pps: here is my +1
+1
Thanks!
Regarding that release candidate. There are still one or two minor
issues on Linux and Windows I think. I will test again and report soon.
cu,
Rudi
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3
support)
Posted by Andi Vajda <va...@apache.org>.
On Wed, 29 Mar 2017, Michael McCandless wrote:
> +1 to release.
>
> I tested on Ubuntu 16.04 with Python 3.5.2 and Java 1.8.0_121.
>
> I ran my usual smoke test of indexing first 100K docs from Wikipedia
> English export and running a few searches. But first I had to run 2to3 on
> this ancient script!
>
> I had to apply Ruediger's patch to JCC's setup.py else it was trying to
> link with -lpython3.5 but I have -lpython3.5m.
Yes, that's the part on Linux that needs editing. I might have to isolate
this into another FLAGS dictionary to make it more obvious. What is the
additional 'm' for ? Is this a Python 3 thing ? In that case, I can just add
it myself and spare everyone else the editing.
Thank you, Mike, for your vote !
Andi..
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Mon, Mar 27, 2017 at 6:12 PM, Andi Vajda <va...@apache.org> wrote:
>
>>
>> The PyLucene 6.5.0 (rc1) release tracking today's release of
>> Apache Lucene 6.5.0 is ready.
>>
>> A release candidate is available from:
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
>>
>> PyLucene 6.5.0 is built with JCC 3.0 included in these release artifacts.
>>
>> JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
>> PyLucene may be built with Python 2 or Python 3.
>>
>> Please vote to release these artifacts as PyLucene 6.5.0.
>> Anyone interested in this release can and should vote !
>>
>> Thanks !
>>
>> Andi..
>>
>> ps: the KEYS file for PyLucene release signing is at:
>> https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
>> https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
>>
>> pps: here is my +1
>>
>
Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Posted by Michael McCandless <lu...@mikemccandless.com>.
+1 to release.
I tested on Ubuntu 16.04 with Python 3.5.2 and Java 1.8.0_121.
I ran my usual smoke test of indexing first 100K docs from Wikipedia
English export and running a few searches. But first I had to run 2to3 on
this ancient script!
I had to apply Ruediger's patch to JCC's setup.py else it was trying to
link with -lpython3.5 but I have -lpython3.5m.
Mike McCandless
http://blog.mikemccandless.com
On Mon, Mar 27, 2017 at 6:12 PM, Andi Vajda <va...@apache.org> wrote:
>
> The PyLucene 6.5.0 (rc1) release tracking today's release of
> Apache Lucene 6.5.0 is ready.
>
> A release candidate is available from:
> https://dist.apache.org/repos/dist/dev/lucene/pylucene/6.5.0-rc1/
>
> PyLucene 6.5.0 is built with JCC 3.0 included in these release artifacts.
>
> JCC 3.0 now supports Python 3.3+ (in addition to Python 2.3+).
> PyLucene may be built with Python 2 or Python 3.
>
> Please vote to release these artifacts as PyLucene 6.5.0.
> Anyone interested in this release can and should vote !
>
> Thanks !
>
> Andi..
>
> ps: the KEYS file for PyLucene release signing is at:
> https://dist.apache.org/repos/dist/release/lucene/pylucene/KEYS
> https://dist.apache.org/repos/dist/dev/lucene/pylucene/KEYS
>
> pps: here is my +1
>