[GitHub] [camel] orpiske commented on a diff in pull request #9978: removing unused parameters from method signature for camel core

["orpiske (via GitHub)" <gi...@apache.org>]

orpiske commented on code in PR #9978:
URL: https://github.com/apache/camel/pull/9978#discussion_r1182732854


##########
core/camel-support/src/main/java/org/apache/camel/support/DefaultContextReloadStrategy.java:
##########
@@ -64,11 +64,11 @@ public void onReload(Object source) {
         }
     }
 
-    protected void reloadRoutes(Object source) throws Exception {
+    protected void reloadRoutes() throws Exception {

Review Comment:
   I am not entirely sure we want to change the signature of `protected` methods.
   
   I am wondering if wouldn't be better to document these methods if they are supposed to be extended by others. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org