You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2014/11/26 15:34:50 UTC

svn commit: r1641824 - /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java

Author: jpountz
Date: Wed Nov 26 14:34:50 2014
New Revision: 1641824

URL: http://svn.apache.org/r1641824
Log:
LUCENE-6076: Remove unnecessary copy (thanks Robert for pointing this out).

Modified:
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java?rev=1641824&r1=1641823&r2=1641824&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/CachingWrapperFilter.java Wed Nov 26 14:34:50 2014
@@ -149,10 +149,9 @@ public class CachingWrapperFilter extend
   @Override
   public Iterable<? extends Accountable> getChildResources() {
     // Sync to pull the current set of values:
-    final Map<Object, DocIdSet> copy;
     synchronized (cache) {
-      copy = new HashMap<>(cache);
+      // no need to clone, Accountable#namedAccountables already copies the data
+      return Accountables.namedAccountables("segment", cache);
     }
-    return Accountables.namedAccountables("segment", copy);
   }
 }