You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Danny Robinson <da...@gmail.com> on 2007/05/08 18:17:05 UTC
[Trinidad] Patch: Client-side validation - enhance to match server-side
Adam,
I've uploaded the latest patch to ensure it works after the move to myfaces,
and any recent changes to files. Could you please take a look and pass
comment, we'd really like this fixed asap, so feedback is greatly
appreciated.
https://issues.apache.org/jira/browse/ADFFACES-391
Thanks,
Danny
--
Chordiant Software Inc.
www.chordiant.com
Re: [Trinidad] Patch: Client-side validation - enhance to match server-side
Posted by Adam Winer <aw...@gmail.com>.
OK, I've got the patch about ready to check in, with the
following changes so far:
- Instead of a web.xml config parameter, I've added a
trinidad-config.xml <client-validation> element, which
supports ALERT, INLINE, and DISABLED (and
deprecated <client-validation-disabled>) - and
added RequestContext.getClientValidation().
- Changed the label + message renderers so that they
only change the output when inline client validation
is enabled.
- Changed __MSG to ::msg, etc. - I like this naming
strategy more.
- The JS validateInput() method has been made private,
because I'd like to start putting JS methods on
namespace objects instead of putting it in the window
object - and it only supports inline validation.
- Core.js had some tabs (needed to be spaces)
I think that's it... other than that, the code is great! Very
sweet seeing this functionality in action while half-paying
attention to the technical keynote. :)
-- Adam
On 5/8/07, Adam Winer <aw...@gmail.com> wrote:
>
> Sorry for the bit-rot... I'll have a look soon - hopefully
> I can fit it in between J1 sessions (or during the
> boring ones :)
>
> -- Adam
>
>
> On 5/8/07, Danny Robinson <da...@gmail.com> wrote:
> > Adam,
> >
> > I've uploaded the latest patch to ensure it works after the move to
> myfaces,
> > and any recent changes to files. Could you please take a look and pass
> > comment, we'd really like this fixed asap, so feedback is greatly
> > appreciated.
> >
> > https://issues.apache.org/jira/browse/ADFFACES-391
> >
> > Thanks,
> >
> > Danny
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>
Re: [Trinidad] Patch: Client-side validation - enhance to match server-side
Posted by Adam Winer <aw...@gmail.com>.
Sorry for the bit-rot... I'll have a look soon - hopefully
I can fit it in between J1 sessions (or during the
boring ones :)
-- Adam
On 5/8/07, Danny Robinson <da...@gmail.com> wrote:
> Adam,
>
> I've uploaded the latest patch to ensure it works after the move to myfaces,
> and any recent changes to files. Could you please take a look and pass
> comment, we'd really like this fixed asap, so feedback is greatly
> appreciated.
>
> https://issues.apache.org/jira/browse/ADFFACES-391
>
> Thanks,
>
> Danny
> --
> Chordiant Software Inc.
> www.chordiant.com