You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/01 04:26:04 UTC
[jira] [Commented] (BEAM-2120) TestDataflowRunner prints all
messages from the job, repeatedly
[ https://issues.apache.org/jira/browse/BEAM-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990574#comment-15990574 ]
ASF GitHub Bot commented on BEAM-2120:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2796
[BEAM-2120] Do not repeat log messages in DataflowPipelineJob
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam DataflowPipelineJob
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2796
----
commit 401eef09a0dc94dc2ed1e4afcaa30259d922ba3f
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-05-01T04:24:23Z
Do not repeat log messages in DataflowPipelineJob
----
> TestDataflowRunner prints all messages from the job, repeatedly
> ---------------------------------------------------------------
>
> Key: BEAM-2120
> URL: https://issues.apache.org/jira/browse/BEAM-2120
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Eugene Kirpichov
> Assignee: Kenneth Knowles
>
> This is due to https://github.com/apache/beam/commit/ed8bd62652126d8d0cf054cee5cc79dda88e3415
> Every call to job.waitUntilFinish() prints all messages because the pagination by lastTimestamp happens inside job.waitUntilFinish() rather than outside.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)