[jira] [Commented] (ZOOKEEPER-1666) Avoid Reverse DNS lookup if the hostname in connection string is literal IP address.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662841#comment-13662841 ] 

Hadoop QA commented on ZOOKEEPER-1666:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12583984/ZOOKEEPER-1666.patch
  against trunk revision 1484527.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1490//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1490//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1490//console

This message is automatically generated.
                
> Avoid Reverse DNS lookup if the hostname in connection string is literal IP address.
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1666
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1666
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>            Reporter: George Cao
>              Labels: patch, test
>         Attachments: ZOOKEEPER-1666.patch, ZOOKEEPER-1666.patch
>
>
> In our ENV, if the InetSocketAddress.getHostName() is called and the host name in the connection string are literal IP address, then the call will trigger a reverse DNS lookup which is very slow.
> And in this situation, the host name can simply set as the IP without causing any problem. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira