[jira] Commented: (HIVE-990) Incorporate CheckStyle into Hive's build.xml

["Paul Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838177#action_12838177 ] 

Paul Yang commented on HIVE-990:
--------------------------------

By default, the VisibilityModifier catches protected variables (http://checkstyle.sf.net/config_design.html) Is the use of 'protected' discouraged? If so, what's the reason?

> Incorporate CheckStyle into Hive's build.xml
> --------------------------------------------
>
>                 Key: HIVE-990
>                 URL: https://issues.apache.org/jira/browse/HIVE-990
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.6.0
>
>         Attachments: checkstyle-errors.html, HIVE-990.patch
>
>
> Hadoop and Pig both have CheckStyle integrated into their build. This is useful for catching
> a variety of errors as well as for enforcing a specific coding style and maintaining good code hygiene.
> We just need to snatch Hadoop's checkstyle.xml and integrate it into Hive's build.xml file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.