You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/15 09:07:45 UTC
[GitHub] [lucenenet] NightOwl888 opened a new issue, #657: Lucene.Net.Analysis.Cjk.CJKBigramFilter.CJKScript is not a valid Flags enum
NightOwl888 opened a new issue, #657:
URL: https://github.com/apache/lucenenet/issues/657
Java has no concept of a flags enum, there are simply "flags" which are added as public constants to a class and fed into a member that accepts an integral number type.
In .NET, we have flags enums. Members that are typed with an enum will show a list of possible values in Intellisense, which makes the APIs simpler to use. We have converted most (all?) of these public constants to either standard enum or flags enum types based on our analysis.
In [`Lucene.Net.Analysis.Cjk.CJKBigramFilter.CJKScript`](https://github.com/apache/lucenenet/blob/3dca1619cc92d91ec2513372a838f4e7b9b86abe/src/Lucene.Net.Analysis.Common/Analysis/Cjk/CJKBigramFilter.cs#L28-L46), we have added an extra `ALL` flag that was [not present in Lucene 4.8.1](https://github.com/apache/lucenenet/blob/3dca1619cc92d91ec2513372a838f4e7b9b86abe/src/Lucene.Net.Analysis.Common/Analysis/Cjk/CJKBigramFilter.cs#L28-L46), however the value assigned to it is not a valid flags enum value, it should be
```c#
/// <summary>
/// bigram flag for all scripts </summary>
ALL = HAN | HIRAGANA | KATAKANA | HANGUL,
```
The commit for this change should be prefixed BREAKING, since it is changing the value of a public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 closed issue #657: Lucene.Net.Analysis.Cjk.CJKBigramFilter.CJKScript is not a valid Flags enum
Posted by GitBox <gi...@apache.org>.
NightOwl888 closed issue #657: Lucene.Net.Analysis.Cjk.CJKBigramFilter.CJKScript is not a valid Flags enum
URL: https://github.com/apache/lucenenet/issues/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org