You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/17 08:56:55 UTC

[GitHub] [iotdb] stormbroken commented on pull request #5266: [IOTDB-2610] Add metrics for compation module

stormbroken commented on pull request #5266:
URL: https://github.com/apache/iotdb/pull/5266#issuecomment-1070560337


   Excellent Job! I think you can consider whether metrics depend on their status before(mainly for hot reload).
   Besides, I suggest that you can add a method in `CompactionMetricManager` to init all defined metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org