You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sanju1198 (via GitHub)" <gi...@apache.org> on 2025/10/29 15:52:29 UTC
[PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
sanju1198 opened a new pull request, #57497:
URL: https://github.com/apache/airflow/pull/57497
This PR fixes an `AttributeError: 'NoneType' object has no attribute 'print'` that occurs when running `prek` inside the Breeze shell.
The `console` object is `None` in a non-TTY environment, and this PR adds `if console:` checks to prevent the script from crashing when `console.print()` is called.
This fixes the bug I found in the #new-contributors Slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #57497:
URL: https://github.com/apache/airflow/pull/57497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57497:
URL: https://github.com/apache/airflow/pull/57497#issuecomment-3474589843
### Backport successfully created: v3-1-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/pull/57649"><img src="https://img.shields.io/badge/PR-57649-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #57497:
URL: https://github.com/apache/airflow/pull/57497#discussion_r2475932311
##########
scripts/ci/prek/mypy_folder.py:
##########
@@ -116,7 +116,8 @@ def get_all_files(folder: str) -> list[str]:
) and not file.as_posix().endswith("src/airflow/providers/__init__.py"):
files_to_check.append(file.relative_to(AIRFLOW_ROOT_PATH).as_posix())
file_spec = "@/files/mypy_files.txt"
- console.print(f"[info]Running mypy with {file_spec}")
+ if console:
Review Comment:
Inline comment to block accidental merge.
As TP mentioned - fallback printing is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57497:
URL: https://github.com/apache/airflow/pull/57497#issuecomment-3462408136
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #57497:
URL: https://github.com/apache/airflow/pull/57497#issuecomment-3464886856
> NICE! Thanks for the investigation and fix !
With the caveat that the comment from @uranusjr will be addressed. In this case indeed the problem is that ich is not importable, but print should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #57497:
URL: https://github.com/apache/airflow/pull/57497#issuecomment-3462706444
You should still print something using built-in `print` instead of just ignoring those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "sanju1198 (via GitHub)" <gi...@apache.org>.
sanju1198 commented on code in PR #57497:
URL: https://github.com/apache/airflow/pull/57497#discussion_r2476256549
##########
scripts/ci/prek/mypy_folder.py:
##########
@@ -116,7 +116,8 @@ def get_all_files(folder: str) -> list[str]:
) and not file.as_posix().endswith("src/airflow/providers/__init__.py"):
files_to_check.append(file.relative_to(AIRFLOW_ROOT_PATH).as_posix())
file_spec = "@/files/mypy_files.txt"
- console.print(f"[info]Running mypy with {file_spec}")
+ if console:
Review Comment:
Thanks @uranusjr and @potiuk! I've pushed the new commit with the print() fallback as suggested.
P.S. I also found and fixed one more console.print crash that was in the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: Prevent AttributeError crash in prek when run inside container [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57497:
URL: https://github.com/apache/airflow/pull/57497#issuecomment-3474587363
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org