[GitHub] [samza] cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267087682
 
 

 ##########
 File path: samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
 ##########
 @@ -110,15 +110,12 @@ class TestKafkaCheckpointManager extends KafkaServerTestHarness {
     kcm1.stop
 
     // check that start actually creates the topic with log compaction enabled
-    val zkClient = ZkUtils(zkConnect, 6000, 6000, JaasUtils.isZkSecurityEnabled())
-    val topicConfig = AdminUtils.fetchEntityConfig(zkClient, ConfigType.Topic, checkpointTopic)
+    val topicConfig = adminZkClient.getAllTopicConfigs().getOrElse(checkpointTopic, new Properties())
 
 Review comment:
   Just double checking: Does `adminZkClient` get managed (including lifecycle like `close`) through `KafkaServerTestHarness` now? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services