[GitHub] [superset] yousoph commented on issue #9990: SQL Lab editor shortcuts override other common shortcuts

["yousoph (via GitHub)" <gi...@apache.org>]

yousoph commented on issue #9990:
URL: https://github.com/apache/superset/issues/9990#issuecomment-1528218265

   ⌘ + return makes sense to me for run query 
   
   If we move Mac shortcuts from Ctrl to ⌘, I think the shortcuts that would conflict are: 
   * New tab: currently Ctrl + t on Macs, Ctrl + q on PCs
   * Stop query: currently Ctrl + x,  Ctrl + e on PCs
   
   Would it make sense to add ⌘ shortcuts onto the existing Ctrl ones for Mac? ie for Run query, users could use ⌘ + return or Ctrl + return and for new tab, users could use Ctrl + t or ⌘ + q? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org