You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2017/12/26 11:02:45 UTC

svn commit: r1819282 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming: SXSSFCell.java SXSSFRow.java

Author: fanningpj
Date: Tue Dec 26 11:02:45 2017
New Revision: 1819282

URL: http://svn.apache.org/viewvc?rev=1819282&view=rev
Log:
Remove misleading SXSSF logging

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java?rev=1819282&r1=1819281&r2=1819282&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java Tue Dec 26 11:02:45 2017
@@ -43,8 +43,8 @@ import org.apache.poi.xssf.usermodel.XSS
 import org.apache.poi.xssf.usermodel.XSSFRichTextString;
 
 /**
- * Streaming version of XSSFRow implementing the "BigGridDemo" strategy.
-*/
+ * Streaming version of XSSFCell implementing the "BigGridDemo" strategy.
+ */
 public class SXSSFCell implements Cell {
     private static final POILogger logger = POILogFactory.getLogger(SXSSFCell.class);
 
@@ -53,7 +53,7 @@ public class SXSSFCell implements Cell {
     private CellStyle _style;
     private Property _firstProperty;
     
-    public SXSSFCell(SXSSFRow row,CellType cellType)
+    public SXSSFCell(SXSSFRow row, CellType cellType)
     {
         _row=row;
         setType(cellType);
@@ -268,8 +268,8 @@ public class SXSSFCell implements Cell {
     /**
      * Set a rich string value for the cell.
      *
-     * @param value  value to set the cell to.  For formulas we'll set the formula
-     * string, for String cells we'll set its value.  For other types we will
+     * @param value  value to set the cell to.  For formulas: we'll set the formula
+     * string, for String cells: we'll set its value.  For other types we will
      * change the cell to a string cell and set its value.
      * If value is null then we will change the cell to a Blank cell.
      */
@@ -284,9 +284,7 @@ public class SXSSFCell implements Cell {
             if (xvalue.length() > SpreadsheetVersion.EXCEL2007.getMaxTextLength()) {
                 throw new IllegalArgumentException("The maximum length of cell contents (text) is 32,767 characters");
             }
-            if (xvalue.hasFormatting())
-                logger.log(POILogger.WARN, "SXSSF doesn't support Shared Strings, rich text formatting information has be lost");
-            
+
             ((RichTextValue)_value).setValue(xvalue);
         } else {
             setCellType(CellType.BLANK);

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java?rev=1819282&r1=1819281&r2=1819282&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java Tue Dec 26 11:02:45 2017
@@ -130,7 +130,7 @@ public class SXSSFRow implements Row, Co
      *
      * @param column - the column number this cell represents
      * @return Cell a high level representation of the created cell.
-     * @throws IllegalArgumentException if columnIndex < 0 or greate than a maximum number of supported columns
+     * @throws IllegalArgumentException if columnIndex < 0 or greater than a maximum number of supported columns
      * (255 for *.xls, 1048576 for *.xlsx)
      */
     @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org