You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ashish Paliwal <pa...@gmail.com> on 2013/07/03 13:20:07 UTC
Review Request 12244: Patch to add SSL support to HTTP Source, Flume-2109
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12244/
-----------------------------------------------------------
Review request for Flume, Hari Shreedharan and Mike Percy.
Bugs: FLUME-2109
https://issues.apache.org/jira/browse/FLUME-2109
Repository: flume-git
Description
-------
Patch for Flume-2109, to add HTTPS support to HTTP Source
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
Diff: https://reviews.apache.org/r/12244/diff/
Testing
-------
Thanks,
Ashish Paliwal
Re: Review Request 12244: Patch to add SSL support to HTTP Source, Flume-2109
Posted by Ashish <pa...@gmail.com>.
Thanks Hari !
I thought about it, but since I was not sure about it, so enabled both
connectors. Shall upload the patch with review comments again, in couple of
hours.
On Wed, Jul 10, 2013 at 6:58 AM, Hari Shreedharan <hshreedharan@cloudera.com
> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12244/
>
> Ashish,
>
> This looks pretty good. Right now it looks like both SSL and non-SSL connectors will be enabled if SSL is enabled. I don't think we should have both enabled - if SSL is enabled only secure connections should be possible. That is how even the Avro Source works right now.
>
>
> - Hari Shreedharan
>
> On July 4th, 2013, 6:08 a.m. UTC, Ashish Paliwal wrote:
> Review request for Flume.
> By Ashish Paliwal.
>
> *Updated July 4, 2013, 6:08 a.m.*
> *Bugs: * FLUME-2109 <https://issues.apache.org/jira/browse/FLUME-2109>
> *Repository: * flume-git
> Description
>
> Patch for Flume-2109, to add HTTPS support to HTTP Source
>
> Testing
>
> Unit Test added to verify SSL messages being sent to the Source.
>
> Diffs
>
> - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java
> (c90f067)
> - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java
> (f547e0f)
> - flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java
> (8952db3)
> - flume-ng-doc/sphinx/FlumeUserGuide.rst (63cad21)
>
> View Diff <https://reviews.apache.org/r/12244/diff/>
>
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: Review Request 12244: Patch to add SSL support to HTTP Source, Flume-2109
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12244/#review22943
-----------------------------------------------------------
Ashish,
This looks pretty good. Right now it looks like both SSL and non-SSL connectors will be enabled if SSL is enabled. I don't think we should have both enabled - if SSL is enabled only secure connections should be possible. That is how even the Avro Source works right now.
- Hari Shreedharan
On July 4, 2013, 6:08 a.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12244/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 6:08 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2109
> https://issues.apache.org/jira/browse/FLUME-2109
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Patch for Flume-2109, to add HTTPS support to HTTP Source
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
> flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
>
> Diff: https://reviews.apache.org/r/12244/diff/
>
>
> Testing
> -------
>
> Unit Test added to verify SSL messages being sent to the Source.
>
>
> Thanks,
>
> Ashish Paliwal
>
>
Re: Review Request 12244: Patch to add SSL support to HTTP Source, Flume-2109
Posted by Ashish Paliwal <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12244/
-----------------------------------------------------------
(Updated July 4, 2013, 6:08 a.m.)
Review request for Flume.
Changes
-------
Added Test case description
Bugs: FLUME-2109
https://issues.apache.org/jira/browse/FLUME-2109
Repository: flume-git
Description
-------
Patch for Flume-2109, to add HTTPS support to HTTP Source
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java c90f067
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java f547e0f
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 8952db3
flume-ng-doc/sphinx/FlumeUserGuide.rst 63cad21
Diff: https://reviews.apache.org/r/12244/diff/
Testing (updated)
-------
Unit Test added to verify SSL messages being sent to the Source.
Thanks,
Ashish Paliwal