You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/24 10:38:39 UTC
[GitHub] [apisix] chalin opened a new pull request #6711: OpenTelemetry plugin: fix links to specification
chalin opened a new pull request #6711:
URL: https://github.com/apache/apisix/pull/6711
Context: https://github.com/open-telemetry/opentelemetry.io/pull/1185
/cc @austinlparker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6711: docs: fix links to OpenTelemetry specification
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #6711:
URL: https://github.com/apache/apisix/pull/6711#discussion_r834864965
##########
File path: docs/en/latest/plugins/opentelemetry.md
##########
@@ -23,9 +23,9 @@ title: opentelemetry
## Description
-[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [opentelemetry specification](https://github.com/open-telemetry/opentelemetry-specification).
+[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [OpenTelemetry specification](https://opentelemetry.io/docs/reference/specification/).
-Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlphttp-request)。
+Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://opentelemetry.io/docs/reference/specification/protocol/otlp/#otlphttp-request).
Review comment:
Thanks for your suggestion, would you like to have it a try ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] chalin commented on a change in pull request #6711: docs: fix links to OpenTelemetry specification
Posted by GitBox <gi...@apache.org>.
chalin commented on a change in pull request #6711:
URL: https://github.com/apache/apisix/pull/6711#discussion_r834869409
##########
File path: docs/en/latest/plugins/opentelemetry.md
##########
@@ -23,9 +23,9 @@ title: opentelemetry
## Description
-[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [opentelemetry specification](https://github.com/open-telemetry/opentelemetry-specification).
+[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [OpenTelemetry specification](https://opentelemetry.io/docs/reference/specification/).
-Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlphttp-request)。
+Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://opentelemetry.io/docs/reference/specification/protocol/otlp/#otlphttp-request).
Review comment:
Sure I can give it a try tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6711: docs: fix links to OpenTelemetry specification
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6711:
URL: https://github.com/apache/apisix/pull/6711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] chalin commented on a change in pull request #6711: OpenTelemetry plugin: fix links to specification
Posted by GitBox <gi...@apache.org>.
chalin commented on a change in pull request #6711:
URL: https://github.com/apache/apisix/pull/6711#discussion_r834161219
##########
File path: docs/en/latest/plugins/opentelemetry.md
##########
@@ -23,9 +23,9 @@ title: opentelemetry
## Description
-[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [opentelemetry specification](https://github.com/open-telemetry/opentelemetry-specification).
+[OpenTelemetry](https://opentelemetry.io/) report Tracing data according to [OpenTelemetry specification](https://opentelemetry.io/docs/reference/specification/).
-Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlphttp-request)。
+Just support reporting in `HTTP` with `Content-Type=application/x-protobuf`, the specification: [OTLP/HTTP Request](https://opentelemetry.io/docs/reference/specification/protocol/otlp/#otlphttp-request).
Review comment:
Note that this sentence doesn't really make sense grammatically. (I chose to only update the link. I'll let someone else rework the sentence if you feel that is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org