You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/01 10:15:19 UTC

Review Request 57197: Add ability to use brace expansion in the dependent keys

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57197/
-----------------------------------------------------------

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20252
    https://issues.apache.org/jira/browse/ambari-20252


Repository: ambari


Description
-------

{{'a.b', 'a.c'}} &rarr; {{'a.{b,c}'}}

Such ability exists in the Ember for a few years and may be implemented in Ambari.


Diffs
-----

  ambari-web/app/utils/ember_reopen.js c7f93af 
  ambari-web/test/utils/ember_reopen_test.js aa50a50 


Diff: https://reviews.apache.org/r/57197/diff/1/


Testing
-------

20571 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko


Re: Review Request 57197: Add ability to use brace expansion in the dependent keys

Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57197/#review167248
-----------------------------------------------------------


Ship it!




Ship It!

- Denys Buzhor


On March 1, 2017, 10:15 a.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57197/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 10:15 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20252
>     https://issues.apache.org/jira/browse/ambari-20252
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {{'a.b', 'a.c'}} &rarr; {{'a.{b,c}'}}
> 
> Such ability exists in the Ember for a few years and may be implemented in Ambari.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/utils/ember_reopen.js c7f93af 
>   ambari-web/test/utils/ember_reopen_test.js aa50a50 
> 
> 
> Diff: https://reviews.apache.org/r/57197/diff/1/
> 
> 
> Testing
> -------
> 
> 20571 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>