You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/19 17:52:00 UTC
[jira] [Commented] (NIFI-4744) Detect incorrect configuration when
using composite user group provider
[ https://issues.apache.org/jira/browse/NIFI-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332635#comment-16332635 ]
ASF GitHub Bot commented on NIFI-4744:
--------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi/pull/2419
NIFI-4744 Detect incorrect authorizers config
Adds stricter checks in AuthorizerFactoryBean for unique ids within
a given type of provider and requires unique providers in composite
and composite-configurable user group providers. Failed validation
checks cause startup to fail. Adds test cases for these new rules.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi NIFI-4744
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2419.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2419
----
commit d1c248d8f80f6c2ecac33eb1bc1a65b814f4cb19
Author: Kevin Doran <kd...@...>
Date: 2018-01-19T16:50:36Z
NIFI-4744 Detect incorrect authorizers config
Adds stricter checks in AuthorizerFactoryBean for unique ids within
a given type of provider and requires unique providers in composite
and composite-configurable user group providers. Failed validation
checks cause startup to fail. Adds test cases for these new rules.
----
> Detect incorrect configuration when using composite user group provider
> -----------------------------------------------------------------------
>
> Key: NIFI-4744
> URL: https://issues.apache.org/jira/browse/NIFI-4744
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Bryan Bende
> Assignee: Kevin Doran
> Priority: Minor
>
> We should be able to detect if the same user group provider is entered more than once in the composite user group provider and fail start up.
> Example config that should fail start up:
> <userGroupProvider>
> <identifier>composite-configurable-user-group-provider</identifier>
> <class>org.apache.nifi.authorization.CompositeConfigurableUserGroupProvider</class>
> <property name="Configurable User Group Provider">file-user-group-provider</property>
> <property name="User Group Provider 1">file-user-group-provider</property>
> <property name="User Group Provider 2">ldap-user-group-provider</property>
> </userGroupProvider>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)