[GitHub] [spark] martin-g commented on a change in pull request #35440: [SPARK-38140][SQL] Desc column stats (min, max) for timestamp type is not consistent with the values due to time zone difference

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #35440:
URL: https://github.com/apache/spark/pull/35440#discussion_r802024367



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -787,7 +789,22 @@ case class DescribeColumnCommand(
       } yield histogramDescription(hist)
       buffer ++= histDesc.getOrElse(Seq(Row("histogram", "NULL")))
     }
-    buffer.toSeq
+    buffer
+  }
+
+  private def toZoneAwareExternalString(s: String, name: String, dataType: DataType): String = {

Review comment:
       please use better variable name for `s`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org