You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by xynny <gi...@git.apache.org> on 2017/10/28 16:26:47 UTC

[GitHub] spark pull request #19597: [SPARK-22375][TEST] Test script can fail if eggs ...

GitHub user xynny opened a pull request:

    https://github.com/apache/spark/pull/19597

    [SPARK-22375][TEST] Test script can fail if eggs are installed by set…

    …up.py during test process
    
    ## What changes were proposed in this pull request?
    
    Ignore the python/.eggs folder when running lint-python
    
    ## How was this patch tested?
    1) put a bad python file in python/.eggs and ran the original script.  results were:
    
    xins-MBP:spark xinlu$ dev/lint-python 
    PEP8 checks failed.
    ./python/.eggs/worker.py:33:4: E121 continuation line under-indented for hanging indent
    ./python/.eggs/worker.py:34:5: E131 continuation line unaligned for hanging indent
    
    
    2) test same situation with change:
    
    xins-MBP:spark xinlu$ dev/lint-python 
    PEP8 checks passed.
    The sphinx-build command was not found. Skipping pydoc checks for now
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xynny/spark SPARK-22375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19597
    
----
commit 956890612db181f5f470593f10fe02048cecaf03
Author: Xin Lu <xl...@salesforce.com>
Date:   2017-10-28T16:23:33Z

    [SPARK-22375][TEST] Test script can fail if eggs are installed by setup.py during test process

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    I think you can add it here instead https://github.com/apache/spark/blob/0e31e28d483918c1de26f78068e78c2ca3cf7f3c/dev/tox.ini#L19


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    **[Test build #83172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83172/testReport)** for PR 19597 at commit [`59efcb8`](https://github.com/apache/spark/commit/59efcb8423b3341942c48ffdd82896ae369ce41b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83172/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    @xynny, mind if I ask your JIRA id?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    **[Test build #83172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83172/testReport)** for PR 19597 at commit [`59efcb8`](https://github.com/apache/spark/commit/59efcb8423b3341942c48ffdd82896ae369ce41b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19597: [SPARK-22375][TEST] Test script can fail if eggs are ins...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19597
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83171/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org