You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "lohit vijayarenu (JIRA)" <ji...@apache.org> on 2008/03/26 08:13:24 UTC

[jira] Created: (HADOOP-3091) hadoop dfs -put should support multiple src

hadoop dfs -put should support multiple src
-------------------------------------------

                 Key: HADOOP-3091
                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
             Project: Hadoop Core
          Issue Type: Improvement
          Components: dfs
    Affects Versions: 0.16.2
            Reporter: lohit vijayarenu


It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
hadoop dfs -put <localsrc> ... <dst>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582174#action_12582174 ] 

Hadoop QA commented on HADOOP-3091:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12378608/HADOOP-3091-1.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 5 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2059/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2059/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2059/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2059/console

This message is automatically generated.

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Status: Open  (was: Patch Available)

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Attachment: HADOOP-3091-1.patch

Here is a patch which takes care of this for -put/-copyFromLocal and -moveFromLocal

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582615#action_12582615 ] 

Hudson commented on HADOOP-3091:
--------------------------------

Integrated in Hadoop-trunk #443 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/443/])

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Status: Open  (was: Patch Available)

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3091:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.17.0
         Assignee: lohit vijayarenu
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Lohit!

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Status: Patch Available  (was: Open)

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Status: Patch Available  (was: Open)

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582364#action_12582364 ] 

Mahadev konar commented on HADOOP-3091:
---------------------------------------

   Path dstPath = new Path(dstf);
+    FileSystem dstFs = dstPath.getFileSystem(getConf());
+    dstFs.copyFromLocalFile(false, false, srcs, new Path(dstf));
+  }

- creates path twice for the same string. 
- the automatic directory creation should not be there. We should error out if the directory does not exist.
- also the hdfs_shell documentation (forrest) needs to be changed :) 


> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582415#action_12582415 ] 

Mahadev konar commented on HADOOP-3091:
---------------------------------------

+1

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Release Note: hadoop dfs -put accepts multiple sources when destination is a directory. 
    Hadoop Flags: [Incompatible change]

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Status: Patch Available  (was: Open)

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582493#action_12582493 ] 

Hadoop QA commented on HADOOP-3091:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12378657/HADOOP-3091-2.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 5 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2069/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2069/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2069/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2069/console

This message is automatically generated.

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3091) hadoop dfs -put should support multiple src

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3091:
-------------------------------------

    Attachment: HADOOP-3091-2.patch

Thanks Mahadev. Attaching new patch modifying as you suggested.

> hadoop dfs -put should support multiple src
> -------------------------------------------
>
>                 Key: HADOOP-3091
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3091
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.2
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3091-1.patch, HADOOP-3091-2.patch
>
>
> It would be good to have hadoop dfs -put to support multiple sources like LINUX cp
> hadoop dfs -put <localsrc> ... <dst>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.