You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by deepti dohare <de...@citrix.com> on 2013/03/12 07:57:00 UTC

Review Request: CLOUDSTACK-1575 Failed to transit volume with uploadVolume

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9869/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and edison su.


Description
-------

CLOUDSTACK-1575 Failed to transit volume with uploadVolume

Reason: CloudStack is again setting the state in registerVolume for which the state has already reached from Allocated -> UploadRequested ->UploadOp. Also, there is no next state available for UploadOp -> UploadRequested -> ?


This addresses bug CLOUDSTACK-1575.


Diffs
-----

  engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java c019374 

Diff: https://reviews.apache.org/r/9869/diff/


Testing
-------

Tested locally. Upload Volume succeeded.


Thanks,

deepti dohare


RE: Review Request: CLOUDSTACK-1575 Failed to transit volume with uploadVolume

Posted by Animesh Chaturvedi <an...@citrix.com>.
Deepti I see Abhi commited your patch, please mark your patch  as submitted

Animesh

> -----Original Message-----
> From: deepti dohare [mailto:noreply@reviews.apache.org] On Behalf Of
> deepti dohare
> Sent: Monday, March 11, 2013 11:57 PM
> To: Edison Su; Devdeep Singh
> Cc: cloudstack; Deepti Dohare
> Subject: Review Request: CLOUDSTACK-1575 Failed to transit volume with
> uploadVolume
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9869/
> -----------------------------------------------------------
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1575 Failed to transit volume with uploadVolume
> 
> Reason: CloudStack is again setting the state in registerVolume for which the
> state has already reached from Allocated -> UploadRequested ->UploadOp.
> Also, there is no next state available for UploadOp -> UploadRequested -> ?
> 
> 
> This addresses bug CLOUDSTACK-1575.
> 
> 
> Diffs
> -----
> 
> 
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/Volum
> eServiceImpl.java c019374
> 
> Diff: https://reviews.apache.org/r/9869/diff/
> 
> 
> Testing
> -------
> 
> Tested locally. Upload Volume succeeded.
> 
> 
> Thanks,
> 
> deepti dohare


Re: Review Request: CLOUDSTACK-1575 Failed to transit volume with uploadVolume

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9869/#review17790
-----------------------------------------------------------


Commit 27b753a434de087a9cd8ec50bfa1deb2de7a7925 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=27b753a ]

CLOUDSTACK-1575 Failed to transit volume with uploadVolume

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On March 12, 2013, 6:56 a.m., deepti dohare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9869/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 6:56 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1575 Failed to transit volume with uploadVolume
> 
> Reason: CloudStack is again setting the state in registerVolume for which the state has already reached from Allocated -> UploadRequested ->UploadOp. Also, there is no next state available for UploadOp -> UploadRequested -> ?
> 
> 
> This addresses bug CLOUDSTACK-1575.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java c019374 
> 
> Diff: https://reviews.apache.org/r/9869/diff/
> 
> 
> Testing
> -------
> 
> Tested locally. Upload Volume succeeded.
> 
> 
> Thanks,
> 
> deepti dohare
> 
>


Re: Review Request: CLOUDSTACK-1575 Failed to transit volume with uploadVolume

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9869/#review17787
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On March 12, 2013, 6:56 a.m., deepti dohare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9869/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 6:56 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and edison su.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1575 Failed to transit volume with uploadVolume
> 
> Reason: CloudStack is again setting the state in registerVolume for which the state has already reached from Allocated -> UploadRequested ->UploadOp. Also, there is no next state available for UploadOp -> UploadRequested -> ?
> 
> 
> This addresses bug CLOUDSTACK-1575.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java c019374 
> 
> Diff: https://reviews.apache.org/r/9869/diff/
> 
> 
> Testing
> -------
> 
> Tested locally. Upload Volume succeeded.
> 
> 
> Thanks,
> 
> deepti dohare
> 
>