You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/15 22:57:40 UTC
Review Request: Fixed slave to not send status updates when the framework is
being shut down.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9964/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
Also pulled out recovering resources logic from inside removeTask(), because we don't want to recover resources when removing a task (e.g., removing a slave).
Diffs
-----
src/master/master.cpp d02a22e1114dd200e274898c76d7c865d5ae8795
src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
src/tests/fault_tolerance_tests.cpp 16031bcab6c7f66b8a0e5e649a5bfeea7c8f6ad0
Diff: https://reviews.apache.org/r/9964/diff/
Testing
-------
make check.
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to not send status updates when the
framework is being shut down.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9964/
-----------------------------------------------------------
(Updated March 16, 2013, 12:33 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk for posterity.
Description
-------
Also pulled out recovering resources logic from inside removeTask(), because we don't want to recover resources when removing a task (e.g., removing a slave).
Diffs (updated)
-----
src/master/master.cpp cf43f00d0e58384221154c047bdedcc9c0b98e54
src/slave/slave.hpp 5fbfc08f8c6fdac61d8615fd42ff604fb37e2dcf
src/slave/slave.cpp d6ff5bc0ef6552441af7e45891a197bed6663696
src/tests/fault_tolerance_tests.cpp 0dc6cf616045650b93a501eb10823ed93d406dc2
Diff: https://reviews.apache.org/r/9964/diff/
Testing
-------
make check.
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to not send status updates when the
framework is being shut down.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9964/
-----------------------------------------------------------
(Updated March 16, 2013, 12:11 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's. also added a check to reject running task for a launching framework.
Description
-------
Also pulled out recovering resources logic from inside removeTask(), because we don't want to recover resources when removing a task (e.g., removing a slave).
Diffs (updated)
-----
src/master/master.cpp d02a22e1114dd200e274898c76d7c865d5ae8795
src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
src/tests/fault_tolerance_tests.cpp 16031bcab6c7f66b8a0e5e649a5bfeea7c8f6ad0
Diff: https://reviews.apache.org/r/9964/diff/
Testing
-------
make check.
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to not send status updates when the
framework is being shut down.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9964/#review18001
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/9964/#comment38021>
Let's just move this to the top.
- Benjamin Hindman
On March 15, 2013, 9:57 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9964/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 9:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Also pulled out recovering resources logic from inside removeTask(), because we don't want to recover resources when removing a task (e.g., removing a slave).
>
>
> Diffs
> -----
>
> src/master/master.cpp d02a22e1114dd200e274898c76d7c865d5ae8795
> src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200
> src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
> src/tests/fault_tolerance_tests.cpp 16031bcab6c7f66b8a0e5e649a5bfeea7c8f6ad0
>
> Diff: https://reviews.apache.org/r/9964/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Vinod Kone
>
>