You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Nick Bailey (JIRA)" <ji...@apache.org> on 2011/02/02 22:47:28 UTC
[jira] Created: (CASSANDRA-2100) Restart required to change
cache_save_period
Restart required to change cache_save_period
--------------------------------------------
Key: CASSANDRA-2100
URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7.0
Reporter: Nick Bailey
Assignee: Jon Hermes
Priority: Minor
Fix For: 0.7.2
The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-2100:
----------------------------------
Attachment: 2100.txt
row/key cache save period in seconds now config-able at runtime via JMX (not just migrations).
On either migration or JMX-change path, the scheduling has been broken out. It first cancels the previous scheduled task (but will not interrupt currently saving caches) then schedules a new task with the correct frequency.
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: 2100.txt
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999473#comment-12999473 ]
Jonathan Ellis commented on CASSANDRA-2100:
-------------------------------------------
I'm not a fan of having side effects in CFMetaData like that.
I checked w/ Gary and his take was, "The saving probably belongs in UpdateColumnFamily. CFMetaData.apply() should only affect a single object—-nothing persistent."
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100-3.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998158#comment-12998158 ]
Jonathan Ellis commented on CASSANDRA-2100:
-------------------------------------------
how does this handle updating when schema changes?
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes reassigned CASSANDRA-2100:
-------------------------------------
Assignee: Matthew F. Dennis (was: Jon Hermes)
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Matthew F. Dennis
> Priority: Minor
> Fix For: 0.7.2
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998621#comment-12998621 ]
Jon Hermes commented on CASSANDRA-2100:
---------------------------------------
I thought that UpdateColumnFamily.applyModels() called CFS.reload() in all cases, but that only happens when the server is not in client mode.
CFMetaData.apply(avro CfDef) will need to call the update logic. Patch forthcoming.
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis reassigned CASSANDRA-2100:
--------------------------------------------
Assignee: Jon Hermes (was: Matthew F. Dennis)
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.2
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2100:
--------------------------------------
Remaining Estimate: 2h
Original Estimate: 2h
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-2100:
----------------------------------
Attachment: 2100-2.txt
Rebased.
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2100:
----------------------------------------
Fix Version/s: (was: 0.7.2)
0.7.3
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100.txt
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999566#comment-12999566 ]
Hudson commented on CASSANDRA-2100:
-----------------------------------
Integrated in Cassandra-0.7 #324 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/324/])
add [get|set][row|key]cacheSavePeriod to JMX
patch by Jon Hermes; reviewed by jbellis for CASSANDRA-2100
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100-3.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-2100:
----------------------------------
Attachment: 2100-3.txt
Slight surprise in testing due to 2172 changes, but tests correctly (save period is updated at runtime for both JMX and schema migrations (both client and non-client mode)).
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100-3.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997557#comment-12997557 ]
Jonathan Ellis commented on CASSANDRA-2100:
-------------------------------------------
can you rebase?
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100.txt
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2100:
--------------------------------------
Reviewer: brandon.williams
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100.txt
>
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2100) Restart required to change
cache_save_period
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999489#comment-12999489 ]
Jon Hermes commented on CASSANDRA-2100:
---------------------------------------
2100-2.txt works fine when the schema changes.
`if (!clientMode) { CFS.reload() }` will reset the config appropriately, and it's good we don't do anything when clientMode because we don't apply() from migration in that case as well (and there would be nothing to reset).
>From your comment I thought that something didn't work. Don't scare me like that. :P
> Restart required to change cache_save_period
> --------------------------------------------
>
> Key: CASSANDRA-2100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Nick Bailey
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 2100-2.txt, 2100-3.txt, 2100.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The cache_save_period is set in the schema for each column family. However this value is only checked when a node starts up so changing this value isn't really dynamic.
> We should actually change this when the schema changes instead of having to restart.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira