You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2018/07/13 17:07:35 UTC
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10942
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
Some downstream tests run this with a fair-scheduler.xml set that, while
not changing admission control behavior, does change the name of the
pool. Omit the pool name to permit that downstream test to succeed.
Testing:
- local with change in minicluster
- downstream in environment as well
Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
---
M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/10942/1
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10942 )
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:19:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10942 )
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:45:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10942 )
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
Some downstream tests run this with a fair-scheduler.xml set that, while
not changing admission control behavior, does change the name of the
pool. Omit the pool name to permit that downstream test to succeed.
Testing:
- local with change in minicluster
- downstream in environment as well
Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Reviewed-on: http://gerrit.cloudera.org:8080/10942
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10942 )
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
Patch Set 2: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:27:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10942 )
Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2813/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe6beb169dc6bfefabde9dc7a4632c1a5e63fa7
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 17:27:21 +0000
Gerrit-HasComments: No