[GitHub] spark pull request #21859: [SPARK-24900][SQL]Speed up sort when the dataset ...

[kiszk <gi...@git.apache.org>]

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21859#discussion_r207817068
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SmallDataSortBenchmark.scala ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.execution.benchmark
    +
    +import java.io.File
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.sql.SparkSession
    +import org.apache.spark.util.{Benchmark, Utils}
    +
    +/**
    +  * The benchmarks aims to measure performance of
    +  * [SPARK-24900][SQL]speed up sort when the dataset is small
    +  */
    +object SmallDataSortBenchmark {
    +
    +  val conf = new SparkConf()
    +
    +  val spark = SparkSession.builder
    +    .master("local[1]")
    +    .appName("speed up sort when the dataset is small")
    +    .config(conf)
    +    .getOrCreate()
    +
    +  import spark.implicits._
    +
    +  def withTempPath(f: File => Unit): Unit = {
    +    val path = Utils.createTempDir()
    +    path.delete()
    +    try f(path) finally Utils.deleteRecursively(path)
    +  }
    +
    +  def run(rowsNum: Int): Unit = {
    +    val factor = 1000
    +    val key = rowsNum / 2
    +    val benchmark = new Benchmark("speed up sort when the dataset is small", rowsNum * factor)
    +    withTempPath { path =>
    +      // scalastyle:off println
    +      benchmark.out.println("Preparing data for benchmarking ...")
    +      // scalastyle:on println
    +
    +      val list = (0 to factor).toList
    +
    +      spark.sparkContext.range(0, rowsNum, 1)
    +        .flatMap(num => {
    +          list.map(x => (num, x))
    +        })
    +        .toDF("key", "value")
    +        .write
    +        .option("encoding", "UTF-8")
    +        .json(path.getAbsolutePath)
    +
    +      benchmark.addCase("sort", 10) { _ =>
    +        val dataset = spark.read.json(path.getAbsolutePath)
    +        dataset.createOrReplaceTempView("src")
    +        val result = spark.
    +          sql(s"select * from src where key = $key order by value").collectAsList().size()
    +
    +      }
    +
    +      benchmark.run()
    --- End diff --
    
    Would you please add the performance results without and with this PR to this space like other benchmarks?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org