You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2019/05/31 22:27:14 UTC
[incubator-superset] branch master updated: [SQL Lab] Prevent
failed query error from disappearing (#7624)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 5895d8c [SQL Lab] Prevent failed query error from disappearing (#7624)
5895d8c is described below
commit 5895d8c8e1f99903d0422c67189f4526cedf80c4
Author: Erik Ritter <er...@airbnb.com>
AuthorDate: Fri May 31 15:27:08 2019 -0700
[SQL Lab] Prevent failed query error from disappearing (#7624)
---
superset/assets/src/SqlLab/reducers/sqlLab.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/superset/assets/src/SqlLab/reducers/sqlLab.js b/superset/assets/src/SqlLab/reducers/sqlLab.js
index a94e817..7a21e82 100644
--- a/superset/assets/src/SqlLab/reducers/sqlLab.js
+++ b/superset/assets/src/SqlLab/reducers/sqlLab.js
@@ -322,7 +322,10 @@ export default function sqlLabReducer(state = {}, action) {
let queriesLastUpdate = state.queriesLastUpdate;
for (const id in action.alteredQueries) {
const changedQuery = action.alteredQueries[id];
- if (!state.queries.hasOwnProperty(id) || state.queries[id].state !== 'stopped') {
+ if (
+ !state.queries.hasOwnProperty(id)
+ || (state.queries[id].state !== 'stopped' && state.queries[id].state !== 'failed')
+ ) {
if (changedQuery.changedOn > queriesLastUpdate) {
queriesLastUpdate = changedQuery.changedOn;
}