You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/11 04:03:22 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
xiaoxiang781216 opened a new pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751
## Summary
follow up PR: https://github.com/apache/incubator-nuttx/pull/1746
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487420793
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691512404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691503663
@patacongo do you have any concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487424789
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487424789
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487420793
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691512404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487424789
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691503663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487424789
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#discussion_r487420793
##########
File path: sched/Kconfig
##########
@@ -920,7 +920,13 @@ config SCHED_INSTRUMENTATION_EXTERNAL
bool "System performance monitor endpoints are external"
default n
---help---
- Monitor only CPUs in the bitset. Bit 0=CPU0, Bit1=CPU1, etc.
+ When this option isn't selected, the common code will implement
Review comment:
This should say what will happen when it is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691503663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-691512404
@xiaoxiang781216 - since you asked for @patacongo 's input, we should give him time to respond. If we do not hear back by say mid Monday his time, we can assume he is OK with this level of the change. Then ping me and I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1751: sched: Refine the comment for SCHED_INSTRUMENTATION_EXTERNAL
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1751:
URL: https://github.com/apache/incubator-nuttx/pull/1751#issuecomment-692303227
I am assuming there was not objection on the naming front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org