You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rpassis <gi...@git.apache.org> on 2014/08/15 07:13:23 UTC

[GitHub] cordova-plugin-geolocation pull request: Adds new key to *-Info.pl...

GitHub user rpassis opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/22

    Adds new key to *-Info.plist file for iOS8 location services compatibili...

    Complements the fix proposed on #21

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rpassis/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit 08ba360caca481882ccd626e071b6338554ee198
Author: Rogerio de Paula Assis <ro...@freshmob.com.au>
Date:   2014-08-15T05:04:38Z

    Adds new key to *-Info.plist file for iOS8 location services compatibility

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-geolocation pull request: Adds new key to *-Info.pl...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/22#issuecomment-54906597
  
    Hi, this is incorrect. It will create two keys (try it), one with "/*" as the key name, and one with the actual key.
    
    The correct usage is here: https://github.com/apache/cordova-plugin-geolocation/blob/4102a332b0c6b0c3513370a4c030a32e46a51e10/plugin.xml#L109-L111 and it is already in a previous commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---