You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/29 08:16:03 UTC

[GitHub] [spark] cloud-fan commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic

cloud-fan commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751990802


   We need to fix https://github.com/apache/spark/pull/30852/files#diff-9723970916a34149cbb2e3a2853614e523a8a00d5a126926c54f23b4b758e3baR96 as well.
   
   To simplify the code, I'd suggest we also turn unspecified else value into false in the rule `ReplaceNullWithFalseInPredicate`. It's idempotent and should not have a real perf impact.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org